Skip to content

[mlir][SMT] fix the operation name in ArrayBroadcastOp description #135746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

Clo91eaf
Copy link
Contributor

@Clo91eaf Clo91eaf commented Apr 15, 2025

llvm/circt#8299
a simple typo fix moved from circt :p
Fixed a minor issue in the SMT description. The SMT dialect does not have smt.declare operation. It should be smt.declare_fun.

@llvmbot llvmbot added the mlir label Apr 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 15, 2025

@llvm/pr-subscribers-mlir

Author: Clo91eaf (Clo91eaf)

Changes

llvm/circt#8299
a simple typo fix moved from circt :p
Fixed a minor issue in the SMT description. The SMT dialect does not have smt.declare operation. It should be smt.declare_fun.


Full diff: https://github.com/llvm/llvm-project/pull/135746.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td b/mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td
index 1869f4ae81595..ac1c2f3ed409a 100644
--- a/mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td
+++ b/mlir/include/mlir/Dialect/SMT/IR/SMTArrayOps.td
@@ -75,7 +75,7 @@ def ArrayBroadcastOp : SMTArrayOp<"broadcast", [
     This operation represents a broadcast of the 'value' operand to all indices
     of the array. It is equivalent to
     ```
-    %0 = smt.declare "array" : !smt.array<[!smt.int -> !smt.bool]>
+    %0 = smt.declare_fun "array" : !smt.array<[!smt.int -> !smt.bool]>
     %1 = smt.forall ["idx"] {
     ^bb0(%idx: !smt.int):
       %2 = smt.array.select %0[%idx] : !smt.array<[!smt.int -> !smt.bool]>

Copy link
Member

@SpriteOvO SpriteOvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@SpriteOvO SpriteOvO merged commit c1fc4c6 into llvm:main Apr 16, 2025
12 of 13 checks passed
var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
@Clo91eaf Clo91eaf deleted the smt-typo-fix branch April 29, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants