Skip to content

[nfc] Add doc comment for canReturn in Analysis/CFG.h #135862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mtrofin
Copy link
Member

@mtrofin mtrofin commented Apr 15, 2025

Also drive-by fix of the // namespace comment.

Copy link
Member Author

mtrofin commented Apr 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mtrofin mtrofin marked this pull request as ready for review April 15, 2025 21:41
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Apr 15, 2025
Copy link
Member Author

mtrofin commented Apr 15, 2025

Merge activity

  • Apr 15, 5:41 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 15, 5:43 PM EDT: A user merged this pull request with Graphite.

@llvmbot
Copy link
Member

llvmbot commented Apr 15, 2025

@llvm/pr-subscribers-llvm-analysis

Author: Mircea Trofin (mtrofin)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/135862.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Analysis/CFG.h (+4-1)
diff --git a/llvm/include/llvm/Analysis/CFG.h b/llvm/include/llvm/Analysis/CFG.h
index 8451e88146d7c..052ffb2872af7 100644
--- a/llvm/include/llvm/Analysis/CFG.h
+++ b/llvm/include/llvm/Analysis/CFG.h
@@ -174,7 +174,10 @@ bool containsIrreducibleCFG(RPOTraversalT &RPOTraversal, const LoopInfoT &LI) {
 
   return false;
 }
+
+/// Return true if there is at least a path through which F can return, false if
+/// there is no such path.
 bool canReturn(const Function &F);
-} // End llvm namespace
+} // namespace llvm
 
 #endif

@mtrofin mtrofin merged commit d037217 into main Apr 15, 2025
10 of 13 checks passed
@mtrofin mtrofin deleted the users/mtrofin/04-15-_nfc_add_doc_comment_for_canreturn_in_analysis/cfg.h branch April 15, 2025 21:43
var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants