[mlir][memref] Mark result memref as "strided" #135939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesWe already check this in the verifier, but this makes it explicit in the Tablegen. Full diff: https://github.com/llvm/llvm-project/pull/135939.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
index 3edc2433c85ea..0cea19964f5f4 100644
--- a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
+++ b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
@@ -1372,7 +1372,7 @@ def MemRef_ReinterpretCastOp
DenseI64ArrayAttr:$static_offsets,
DenseI64ArrayAttr:$static_sizes,
DenseI64ArrayAttr:$static_strides);
- let results = (outs AnyMemRef:$result);
+ let results = (outs AnyStridedMemRef:$result);
let assemblyFormat = [{
$source `to` `offset` `` `:`
|
|
@llvm/pr-subscribers-mlir-memref Author: Matthias Springer (matthias-springer) ChangesWe already check this in the verifier, but this makes it explicit in the Tablegen. Full diff: https://github.com/llvm/llvm-project/pull/135939.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
index 3edc2433c85ea..0cea19964f5f4 100644
--- a/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
+++ b/mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
@@ -1372,7 +1372,7 @@ def MemRef_ReinterpretCastOp
DenseI64ArrayAttr:$static_offsets,
DenseI64ArrayAttr:$static_sizes,
DenseI64ArrayAttr:$static_strides);
- let results = (outs AnyMemRef:$result);
+ let results = (outs AnyStridedMemRef:$result);
let assemblyFormat = [{
$source `to` `offset` `` `:`
|
qcolombet
approved these changes
Apr 16, 2025
matthias-springer
deleted the
users/matthias-springer/reinterpret_cast_strided
branch
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
We already check this in the verifier, but this makes it explicit in the Tablegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already check this in the verifier, but this makes it explicit in the Tablegen.