Skip to content

[lldb] Try to fix TestExprDiagnostics test #136269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

tbaederr
Copy link
Contributor

No description provided.

@tbaederr tbaederr requested a review from JDevlieghere as a code owner April 18, 2025 06:44
@llvmbot llvmbot added the lldb label Apr 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 18, 2025

@llvm/pr-subscribers-lldb

Author: Timm Baeder (tbaederr)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136269.diff

1 Files Affected:

  • (modified) lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py (+4-4)
diff --git a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
index b476a807c6dc0..428dbd0a85234 100644
--- a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
+++ b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
@@ -33,7 +33,7 @@ def test_source_and_caret_printing(self):
         self.assertIn(
             """
     1 | unknown_identifier
-      | ^
+      | ^~~~~~~~~~~~~~~~~~
 """,
             value.GetError().GetCString(),
         )
@@ -45,7 +45,7 @@ def test_source_and_caret_printing(self):
         self.assertIn(
             """
     1 | 1 + unknown_identifier
-      |     ^
+      |     ^~~~~~~~~~~~~~~~~~
 """,
             value.GetError().GetCString(),
         )
@@ -57,7 +57,7 @@ def test_source_and_caret_printing(self):
         self.assertIn(
             """
     2 | foobar +=1;
-      | ^
+      | ^~~~~~
 """,
             value.GetError().GetCString(),
         )
@@ -74,7 +74,7 @@ def test_source_and_caret_printing(self):
         self.assertIn(
             """
     1 | void foo(unknown_type x) {}
-      |          ^
+      |          ^~~~~~~~~~~~
 """,
             value.GetError().GetCString(),
         )

@tbaederr tbaederr force-pushed the lldb-test branch 2 times, most recently from 080087a to 04e355e Compare April 18, 2025 07:04
@tbaederr tbaederr merged commit 802e730 into llvm:main Apr 18, 2025
10 checks passed
@adrian-prantl
Copy link
Collaborator

Why did this break?

@tbaederr
Copy link
Contributor Author

I broke it with #117671

IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Add missing source ranges to the diagnostic output.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Add missing source ranges to the diagnostic output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants