Skip to content

[clang][bytecode] Diagnose failed MemberPtrPtr casts differently #136407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

[clang][bytecode] Diagnose failed MemberPtrPtr casts differently #136407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/AST/ByteCode/Interp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,7 +1932,7 @@ inline bool CastMemberPtrPtr(InterpState &S, CodePtr OpPC) {
S.Stk.push<Pointer>(*Ptr);
return true;
}
return false;
return Invalid(S, OpPC);
}

//===----------------------------------------------------------------------===//
Expand Down
18 changes: 18 additions & 0 deletions clang/test/AST/ByteCode/memberpointers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,3 +249,21 @@ namespace CallExprTypeMismatch {
}
static_assert(test(), "");
}

namespace CastMemberPtrPtrFailed{
struct S {
constexpr S() {}
constexpr int f() const;
constexpr int g() const;
};
struct T : S {
constexpr T(int n) : S(), n(n) {}
int n;
};

constexpr int S::g() const {
return this->*(int(S::*))&T::n; // both-note {{subexpression}}
}
static_assert(S().g(), ""); // both-error {{constant expression}} \
// both-note {{in call to 'S().g()'}}
}
Loading