[clang][bytecode] Don't set OnePastEnd bit for array elements #136422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) ChangesIf we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index. Full diff: https://github.com/llvm/llvm-project/pull/136422.diff 2 Files Affected:
diff --git a/clang/lib/AST/ByteCode/Pointer.cpp b/clang/lib/AST/ByteCode/Pointer.cpp
index 686ec381d232a..059503cae3561 100644
--- a/clang/lib/AST/ByteCode/Pointer.cpp
+++ b/clang/lib/AST/ByteCode/Pointer.cpp
@@ -223,6 +223,7 @@ APValue Pointer::toAPValue(const ASTContext &ASTCtx) const {
UsePath = false;
// Build the path into the object.
+ bool OnePastEnd = isOnePastEnd();
Pointer Ptr = *this;
while (Ptr.isField() || Ptr.isArrayElement()) {
@@ -251,9 +252,10 @@ APValue Pointer::toAPValue(const ASTContext &ASTCtx) const {
Ptr = Ptr.expand();
const Descriptor *Desc = Ptr.getFieldDesc();
unsigned Index;
- if (Ptr.isOnePastEnd())
+ if (Ptr.isOnePastEnd()) {
Index = Ptr.getArray().getNumElems();
- else
+ OnePastEnd = false;
+ } else
Index = Ptr.getIndex();
QualType ElemType = Desc->getElemQualType();
@@ -304,8 +306,7 @@ APValue Pointer::toAPValue(const ASTContext &ASTCtx) const {
std::reverse(Path.begin(), Path.end());
if (UsePath)
- return APValue(Base, Offset, Path,
- /*IsOnePastEnd=*/!isElementPastEnd() && isOnePastEnd());
+ return APValue(Base, Offset, Path, OnePastEnd);
return APValue(Base, Offset, APValue::NoLValuePath());
}
diff --git a/clang/test/AST/ByteCode/arrays.cpp b/clang/test/AST/ByteCode/arrays.cpp
index e50839e0f0877..934c3a3e7aff1 100644
--- a/clang/test/AST/ByteCode/arrays.cpp
+++ b/clang/test/AST/ByteCode/arrays.cpp
@@ -761,3 +761,13 @@ namespace PointerSubscript {
struct S{};
static_assert((foo<S>(), true));
}
+
+namespace OnePastEndDiag {
+
+ constexpr int a(const int *b) {
+ return *b; // both-note {{read of dereferenced one-past-the-end pointer}}
+ }
+ constexpr int foo[] = {1,2};
+ constexpr int k = a(foo + 2); // both-error {{must be initialized by a constant expression}} \
+ // both-note {{in call to 'a(&foo[2])'}}
+}
|
cor3ntin
approved these changes
Apr 19, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/199/builds/2873 Here is the relevant piece of the build log for the reference |
hnrklssn
added a commit
to hnrklssn/llvm-project
that referenced
this pull request
Apr 24, 2025
Update clang/test/AST/ByteCode/cxx20.cpp to align with the new behaviour in 6196b4e (llvm#136422).
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…36422) If we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…36422) If we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…36422) If we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we refer to arr[N], don't set the OnePastEnd bit of the APValue, since that is already encoded in the array index.