Skip to content

[X86] Remove unused BitVector TILERegs (NFC) #136508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Apr 20, 2025

It is not used.

@llvmbot
Copy link
Member

llvmbot commented Apr 20, 2025

@llvm/pr-subscribers-backend-x86

Author: AZero13 (AZero13)

Changes

It is not used.


Full diff: https://github.com/llvm/llvm-project/pull/136508.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86LowerTileCopy.cpp (-2)
diff --git a/llvm/lib/Target/X86/X86LowerTileCopy.cpp b/llvm/lib/Target/X86/X86LowerTileCopy.cpp
index fe13ebc6c7675..a4845c0b67efa 100644
--- a/llvm/lib/Target/X86/X86LowerTileCopy.cpp
+++ b/llvm/lib/Target/X86/X86LowerTileCopy.cpp
@@ -79,8 +79,6 @@ bool X86LowerTileCopy::runOnMachineFunction(MachineFunction &MF) {
   const TargetRegisterInfo *TRI = ST.getRegisterInfo();
   BitVector GR64Regs =
       TRI->getAllocatableSet(MF, TRI->getRegClass(X86::GR64RegClassID));
-  BitVector TILERegs =
-      TRI->getAllocatableSet(MF, TRI->getRegClass(X86::TILERegClassID));
   bool Changed = false;
 
   for (MachineBasicBlock &MBB : MF) {

@AZero13 AZero13 changed the title [X86] Remove unused BitVector TILERegs [X86] Remove unused BitVector TILERegs (NFC) Apr 20, 2025
Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RKSimon RKSimon merged commit 47ca7f1 into llvm:main Apr 21, 2025
11 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Apr 21, 2025

LLVM Buildbot has detected a new failure on builder flang-x86_64-windows running on minipc-ryzen-win while building llvm at step 8 "test-build-unified-tree-check-flang-rt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/166/builds/1265

Here is the relevant piece of the build log for the reference
Step 8 (test-build-unified-tree-check-flang-rt) failure: test (failure)
******************** TEST 'flang-rt-Unit :: Runtime/./RuntimeTests.exe/1/8' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\buildbot\flang-x86_64-windows\build\runtimes\runtimes-bins\flang-rt\unittests\Runtime\.\RuntimeTests.exe-flang-rt-Unit-7368-1-8.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=8 GTEST_SHARD_INDEX=1 C:\buildbot\flang-x86_64-windows\build\runtimes\runtimes-bins\flang-rt\unittests\Runtime\.\RuntimeTests.exe
--

Note: This is test shard 2 of 8.

[==========] Running 28 tests from 22 test suites.

[----------] Global test environment set-up.

[----------] 1 test from AllocatableTest

[ RUN      ] AllocatableTest.AllocateFromScalarSource

[       OK ] AllocatableTest.AllocateFromScalarSource (0 ms)

[----------] 1 test from AllocatableTest (0 ms total)



[----------] 1 test from CharacterTests

[ RUN      ] CharacterTests.CharacterAppend1Overrun

[       OK ] CharacterTests.CharacterAppend1Overrun (0 ms)

[----------] 1 test from CharacterTests (0 ms total)



[----------] 1 test from CharacterComparisonTests/1, where TypeParam = <type>

[ RUN      ] CharacterComparisonTests/1.CompareCharacters

[       OK ] CharacterComparisonTests/1.CompareCharacters (0 ms)

[----------] 1 test from CharacterComparisonTests/1 (0 ms total)



[----------] 1 test from ExtremumTests/2, where TypeParam = <type>

[ RUN      ] ExtremumTests/2.MinTests

[       OK ] ExtremumTests/2.MinTests (0 ms)

[----------] 1 test from ExtremumTests/2 (0 ms total)

...

IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants