-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[RISCV][NFC] Delete RISCVAsmParser::parsePseudoQCJumpSymbol #136552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix, warning: RISCVAsmParser::parsePseudoQCJumpSymbol(llvm::OperandVector&)’ defined but not used [-Wunused-function]
@llvm/pr-subscribers-backend-risc-v Author: Liao Chunyu (ChunyuLiao) Changesfix, warning: Full diff: https://github.com/llvm/llvm-project/pull/136552.diff 1 Files Affected:
diff --git a/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp b/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
index db9ec7ae1df02..6cec11a48d042 100644
--- a/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
+++ b/llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
@@ -202,7 +202,6 @@ class RISCVAsmParser : public MCTargetAsmParser {
ParseStatus parseOperandWithSpecifier(OperandVector &Operands);
ParseStatus parseBareSymbol(OperandVector &Operands);
ParseStatus parseCallSymbol(OperandVector &Operands);
- ParseStatus parsePseudoQCJumpSymbol(OperandVector &Operands);
ParseStatus parsePseudoJumpSymbol(OperandVector &Operands);
ParseStatus parseJALOffset(OperandVector &Operands);
ParseStatus parseVTypeI(OperandVector &Operands);
@@ -2139,23 +2138,6 @@ ParseStatus RISCVAsmParser::parseCallSymbol(OperandVector &Operands) {
return ParseStatus::Success;
}
-ParseStatus RISCVAsmParser::parsePseudoQCJumpSymbol(OperandVector &Operands) {
- SMLoc S = getLoc();
- const MCExpr *Res;
-
- if (getLexer().getKind() != AsmToken::Identifier)
- return ParseStatus::NoMatch;
-
- std::string Identifier(getTok().getIdentifier());
- SMLoc E = getTok().getEndLoc();
- Lex();
-
- MCSymbol *Sym = getContext().getOrCreateSymbol(Identifier);
- Res = MCSymbolRefExpr::create(Sym, getContext());
- Operands.push_back(RISCVOperand::createImm(Res, S, E, isRV64()));
- return ParseStatus::Success;
-}
-
ParseStatus RISCVAsmParser::parsePseudoJumpSymbol(OperandVector &Operands) {
SMLoc S = getLoc();
SMLoc E;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/7748 Here is the relevant piece of the build log for the reference
|
fix, warning:
RISCVAsmParser::parsePseudoQCJumpSymbol(llvm::OperandVector&)’ defined but not used [-Wunused-function]