[CIR] Change 'CIR-int' to use a 'APIntParameter' argument #136713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter.
llvmbot
added
clang
|
@llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) ChangesAfter 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter. I don't believe we need to put this in the incubator, as it'll get this in the same Full diff: https://github.com/llvm/llvm-project/pull/136713.diff 1 Files Affected:
diff --git a/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td b/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
index dfe15a10fa54e..293b83e70eff7 100644
--- a/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
+++ b/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
@@ -114,7 +114,7 @@ def IntAttr : CIR_Attr<"Int", "int", [TypedAttrInterface]> {
value of the specified integer type.
}];
let parameters = (ins AttributeSelfTypeParameter<"">:$type,
- "llvm::APInt":$value);
+ APIntParameter<"">:$value);
let builders = [
AttrBuilderWithInferredContext<(ins "mlir::Type":$type,
"const llvm::APInt &":$value), [{
|
|
I'm not terribly sure of the implications of this patch, but figured I'd get one up that at least lets us build. |
|
LGTM |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter. I don't believe we need to put this in the incubator, as it'll get this in the same pulldown as the diagnostic.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter. I don't believe we need to put this in the incubator, as it'll get this in the same pulldown as the diagnostic.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter. I don't believe we need to put this in the incubator, as it'll get this in the same pulldown as the diagnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter.
I don't believe we need to put this in the incubator, as it'll get this in the same
pulldown as the diagnostic.