Skip to content

[LLVM][TableGen] Do not test fixed opcode value in DecoderEmitter tests #136724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Apr 22, 2025

Fix test to allow any opcode values for the OPC_Decode checks, since the specific opcode value can be different for downstream configurations.

Fix test to allow any opcode values for the OPC_Decode checks, since the
specific opcode value can be different for downstream configurations.
@jurahul jurahul marked this pull request as ready for review April 22, 2025 16:07
Copy link
Contributor

@evodius96 evodius96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!!

@jurahul
Copy link
Contributor Author

jurahul commented Apr 22, 2025

NP, sorry for any churn. Will commit once checks are green

@jurahul jurahul merged commit fcb3097 into llvm:main Apr 22, 2025
14 checks passed
@jurahul jurahul deleted the fix_test branch April 22, 2025 18:27
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…ts (llvm#136724)

Fix test to allow any opcode values for the OPC_Decode checks, since the
specific opcode value can be different for downstream configurations.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…ts (llvm#136724)

Fix test to allow any opcode values for the OPC_Decode checks, since the
specific opcode value can be different for downstream configurations.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…ts (llvm#136724)

Fix test to allow any opcode values for the OPC_Decode checks, since the
specific opcode value can be different for downstream configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants