Skip to content

[clang] XFAIL the Xclangas.s test on AIX. #136744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Apr 22, 2025

Clang on AIX does not use the integrated assembler.

#100714 (comment)

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Apr 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-clang-driver

Author: Alex Rønne Petersen (alexrp)

Changes

Clang on AIX does not use the integrated assembler.

#100714 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/136744.diff

1 Files Affected:

  • (modified) clang/test/Driver/Xclangas.s (+1)
diff --git a/clang/test/Driver/Xclangas.s b/clang/test/Driver/Xclangas.s
index 0d3911170eee1..fb6ae2ecbb189 100644
--- a/clang/test/Driver/Xclangas.s
+++ b/clang/test/Driver/Xclangas.s
@@ -2,3 +2,4 @@
 // RUN: %clang -### -Werror -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | FileCheck %s
 // CHECK: -cc1as
 // CHECK-SAME: "-target-feature" "+v5t"
+// XFAIL: target={{.*}}-aix{{.*}}

@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-clang

Author: Alex Rønne Petersen (alexrp)

Changes

Clang on AIX does not use the integrated assembler.

#100714 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/136744.diff

1 Files Affected:

  • (modified) clang/test/Driver/Xclangas.s (+1)
diff --git a/clang/test/Driver/Xclangas.s b/clang/test/Driver/Xclangas.s
index 0d3911170eee1..fb6ae2ecbb189 100644
--- a/clang/test/Driver/Xclangas.s
+++ b/clang/test/Driver/Xclangas.s
@@ -2,3 +2,4 @@
 // RUN: %clang -### -Werror -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | FileCheck %s
 // CHECK: -cc1as
 // CHECK-SAME: "-target-feature" "+v5t"
+// XFAIL: target={{.*}}-aix{{.*}}

Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexrp alexrp merged commit 0de2f64 into llvm:main Apr 23, 2025
14 checks passed
@alexrp alexrp deleted the xfail-clangas-test branch April 23, 2025 21:18
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Clang on AIX does not use the integrated assembler.

llvm#100714 (comment)
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Clang on AIX does not use the integrated assembler.

llvm#100714 (comment)
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Clang on AIX does not use the integrated assembler.

llvm#100714 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants