SelectionDAG: Add missing AddNodeIDCustom case for MDNodeSDNode. #136805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
|
@llvm/pr-subscribers-llvm-selectiondag Author: Peter Collingbourne (pcc) ChangesWithout this we ended up never deduplicating MDNodeSDNodes. Full diff: https://github.com/llvm/llvm-project/pull/136805.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index a41efd58ce4e4..0a2687a16a80c 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -967,6 +967,9 @@ static void AddNodeIDCustom(FoldingSetNodeID &ID, const SDNode *N) {
case ISD::INTRINSIC_W_CHAIN:
// Handled by MemIntrinsicSDNode check after the switch.
break;
+ case ISD::MDNODE_SDNODE:
+ ID.AddPointer(cast<MDNodeSDNode>(N)->getMD());
+ break;
} // end switch (N->getOpcode())
// MemIntrinsic nodes could also have subclass data, address spaces, and flags
|
|
Testcase? |
arsenm
approved these changes
Apr 23, 2025
The only symptom of this bug that I'm aware of is that the backend is slower (because the nodes are never deduplicated) and I'm not sure that we can write a test case for that. |
pcc
deleted the
users/pcc/spr/selectiondag-add-missing-addnodeidcustom-case-for-mdnodesdnode
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 6, 2025
…DNode. Without this we ended up never deduplicating MDNodeSDNodes. Reviewers: arsenm Reviewed By: arsenm Pull Request: llvm/llvm-project#136805
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Without this we ended up never deduplicating MDNodeSDNodes. Reviewers: arsenm Reviewed By: arsenm Pull Request: llvm#136805
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Without this we ended up never deduplicating MDNodeSDNodes. Reviewers: arsenm Reviewed By: arsenm Pull Request: llvm#136805
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Without this we ended up never deduplicating MDNodeSDNodes. Reviewers: arsenm Reviewed By: arsenm Pull Request: llvm#136805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we ended up never deduplicating MDNodeSDNodes.