-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[VPlan] Replace ExtractFromEnd with Extract(Last|Penultimate)Element (NFC). #137030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
876f977
[VPlan] Replace ExtractFromEnd with Extract(Last|Penultimate)Lane (NFC).
fhahn 80d1d0e
Merge remote-tracking branch 'origin/main' into vplan-replace-extract…
fhahn 65178dd
!fixup address latest comments, thanks
fhahn 20740c7
Merge remote-tracking branch 'origin/main' into vplan-replace-extract…
fhahn e5ecd86
!fixup Lane->Element
fhahn 1a5a728
Merge remote-tracking branch 'origin/main' into vplan-replace-extract…
fhahn 733f4b5
!fixup remove retrieving
fhahn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -337,16 +337,18 @@ void UnrollState::unrollBlock(VPBlockBase *VPB) { | |||||||
continue; | ||||||||
} | ||||||||
VPValue *Op0; | ||||||||
if (match(&R, m_VPInstruction<VPInstruction::ExtractFromEnd>( | ||||||||
m_VPValue(Op0), m_VPValue(Op1)))) { | ||||||||
if (match(&R, m_VPInstruction<VPInstruction::ExtractLastElement>( | ||||||||
m_VPValue(Op0))) || | ||||||||
match(&R, m_VPInstruction<VPInstruction::ExtractPenultimateElement>( | ||||||||
m_VPValue(Op0)))) { | ||||||||
addUniformForAllParts(cast<VPSingleDefRecipe>(&R)); | ||||||||
if (Plan.hasScalarVFOnly()) { | ||||||||
// Extracting from end with VF = 1 implies retrieving the scalar part UF | ||||||||
// - Op1. | ||||||||
auto *I = cast<VPInstruction>(&R); | ||||||||
// Extracting from end with VF = 1 implies retrieving the last or | ||||||||
// penultimate scalar part (UF-1 or UF-2). | ||||||||
unsigned Offset = | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trying to simplify:
Suggested change
consistent with how VPInstruction::generate() computes Offset? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done, using cast, thanks |
||||||||
cast<ConstantInt>(Op1->getLiveInIRValue())->getZExtValue(); | ||||||||
R.getVPSingleValue()->replaceAllUsesWith( | ||||||||
getValueForPart(Op0, UF - Offset)); | ||||||||
I->getOpcode() == VPInstruction::ExtractLastElement ? 1 : 2; | ||||||||
I->replaceAllUsesWith(getValueForPart(Op0, UF - Offset)); | ||||||||
R.eraseFromParent(); | ||||||||
} else { | ||||||||
// Otherwise we extract from the last part. | ||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle simpler vector VF case first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do separately, leaving as-is for now to not pull in unrelated changes.