[CMake] Fix the check for Windows vs ccache #137238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for. This mistake seems to have been present all since support for ccache on Windows was added in a4425cc.
|
Is there any reason why this shouldn't just check CMAKE_HOST_SYSTEM_NAME? |
It could check that as well, but |
Fair enough, works the same either way so I suppose it's just down to stylistic preference. |
mrkajetanp
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
LGTM, but it's probably best to wait for @petrhosek before merging given that I'm not the maintainer for this file. Nice catch in any case!
petrhosek
approved these changes
Apr 25, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/10506 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2783 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for. This mistake seems to have been present all since support for ccache on Windows was added in a4425cc.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for. This mistake seems to have been present all since support for ccache on Windows was added in a4425cc.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for. This mistake seems to have been present all since support for ccache on Windows was added in a4425cc.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for. This mistake seems to have been present all since support for ccache on Windows was added in a4425cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the host OS matters for how to interact with ccache, not the target OS that we may be cross compiling for.
This mistake seems to have been present all since support for ccache on Windows was added in
a4425cc.