Skip to content

[lldb] Fix error that lead Windows to think it could reverse execute #137351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

[lldb] Fix error that lead Windows to think it could reverse execute #137351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
Status ProcessWindows::DoResume(RunDirection direction) {
Log *log = GetLog(WindowsLog::Process);
llvm::sys::ScopedLock lock(m_mutex);
Status error;

if (direction == RunDirection::eRunReverse) {
error.FromErrorStringWithFormatv(
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
GetPluginName());
return error;
}

Status error;

StateType private_state = GetPrivateState();
if (private_state == eStateStopped || private_state == eStateCrashed) {
LLDB_LOG(log, "process {0} is in state {1}. Resuming...",
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ Status ProcessGDBRemote::DoResume(RunDirection direction) {
LLDB_LOGF(log, "ProcessGDBRemote::DoResume: target does not "
"support reverse-continue");
return Status::FromErrorString(
"target does not support reverse-continue");
"target does not support reverse execution of processes");
}

if (num_continue_C_tids > 0) {
Expand Down
5 changes: 3 additions & 2 deletions lldb/test/API/commands/process/reverse-continue/TestReverseContinueNotSupported.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@


class TestReverseContinueNotSupported(TestBase):
@skipIfWindows
def test_reverse_continue_not_supported(self):
target = self.connect()

Expand All @@ -26,7 +25,9 @@ def test_reverse_continue_not_supported(self):
self.expect(
"process continue --reverse",
error=True,
substrs=["target does not support reverse-continue"],
# This error is "<plugin name> does not support...". The plugin name changes
# between platforms.
substrs=["does not support reverse execution of processes"],
)

def test_reverse_continue_forward_and_reverse(self):
Expand Down
Loading