Skip tests if socket name is longer than 107 bytes #137405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Emre Kultursay (emrekultursay) ChangesTo fix the test failures introduced in Commit 488eeb3 Full diff: https://github.com/llvm/llvm-project/pull/137405.diff 1 Files Affected:
diff --git a/lldb/unittests/Host/SocketTest.cpp b/lldb/unittests/Host/SocketTest.cpp
index 5bfb48b52f7e7..df67943892420 100644
--- a/lldb/unittests/Host/SocketTest.cpp
+++ b/lldb/unittests/Host/SocketTest.cpp
@@ -349,6 +349,10 @@ TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
ASSERT_FALSE(EC);
llvm::sys::path::append(name, "test");
+ // Skip the test if the $TMPDIR is too long to hold a domain socket.
+ if (name.size() > 107u)
+ return;
+
DomainSocket socket(true);
Status error = socket.Listen(name, /*backlog=*/10);
ASSERT_THAT_ERROR(error.takeError(), llvm::Succeeded());
@@ -369,6 +373,10 @@ TEST_F(SocketTest, AbstractSocketFromBoundNativeSocket) {
llvm::sys::fs::createUniquePath("AbstractSocketFromBoundNativeSocket", name,
true);
llvm::sys::path::append(name, "test");
+
+ // Skip the test if the $TMPDIR is too long to hold a domain socket.
+ if (name.size() > 107u)
+ return;
AbstractSocket socket;
Status error = socket.Listen(name, /*backlog=*/10);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
To fix the test failures introduced in Commit 488eeb3
emrekultursay
force-pushed
the
fix_failing_test
branch
from
d7ab4d2 to
65de315
Compare
JDevlieghere
approved these changes
Apr 25, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/21023 Here is the relevant piece of the build log for the reference |
labath
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Abstract sockets aren't tied to the filesystem, so you don't need to make them "be in" any particular directory, or even look like a path. The only reason I suggested to use createUniquePath is because it's a convenient way to create a random (path-like) string, but it looks like you're not making use of that (the first argument to this function has a slightly different meaning than it does for createUniqueDirectory).
The way I envisioned that is to do a
createUniquePath("AbstractSocketFromBoundNativeSocket-%%%%%%%%", name, /*MakeAbsolute=*/false);
.. though now that I think about it, it may be even better to detach this from the file system completely and use something like UUID::Generate().GetAsString() to generate a random name.
jyli0116
pushed a commit
to jyli0116/llvm-project
that referenced
this pull request
Apr 28, 2025
To fix the test failures introduced in Commit 488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
To fix the test failures introduced in Commit 488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
To fix the test failures introduced in Commit 488eeb3
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
To fix the test failures introduced in Commit 488eeb3
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
To fix the test failures introduced in Commit 488eeb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the test failures introduced in Commit 488eeb3