Skip to content

[lldb] Do not use DomainSocket on Windows #137415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slydiman
Copy link
Contributor

The buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green.

The buildbot lldb-remote-linux-win is broken after llvm#136466.
This patch should make it green.
@slydiman slydiman added the lldb label Apr 25, 2025
@slydiman slydiman requested a review from labath April 25, 2025 23:12
@slydiman slydiman requested a review from JDevlieghere as a code owner April 25, 2025 23:12
@llvmbot
Copy link
Member

llvmbot commented Apr 25, 2025

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

The buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green.


Full diff: https://github.com/llvm/llvm-project/pull/137415.diff

1 Files Affected:

  • (modified) lldb/tools/lldb-server/lldb-platform.cpp (+6)
diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp
index b9a85370d649c..10d79c63af994 100644
--- a/lldb/tools/lldb-server/lldb-platform.cpp
+++ b/lldb/tools/lldb-server/lldb-platform.cpp
@@ -469,6 +469,7 @@ int main_platform(int argc, char *argv[]) {
     if (gdbserver_port) {
       socket = std::make_unique<TCPSocket>(sockfd, /*should_close=*/true);
     } else {
+#if LLDB_ENABLE_POSIX
       llvm::Expected<std::unique_ptr<DomainSocket>> domain_socket =
           DomainSocket::FromBoundNativeSocket(sockfd, /*should_close=*/true);
       if (!domain_socket) {
@@ -477,6 +478,11 @@ int main_platform(int argc, char *argv[]) {
         return socket_error;
       }
       socket = std::move(domain_socket.get());
+#else
+      WithColor::error() << "lldb-platform child: Unix domain sockets are not "
+                            "supported on this platform.";
+      return socket_error;
+#endif
     }
 
     GDBRemoteCommunicationServerPlatform platform(socket->GetSocketProtocol(),

@slydiman
Copy link
Contributor Author

Duplicate of #137414.

@slydiman slydiman closed this Apr 25, 2025
@slydiman slydiman deleted the fix-lldb-server-DomainSocket branch June 23, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants