-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc][bazel] Make top section of BUILD.bazel files more uniform. #137689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
@llvm/pr-subscribers-libc Author: Alexey Samsonov (vonosmas) ChangesMake sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions. Full diff: https://github.com/llvm/llvm-project/pull/137689.diff 3 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
index ccad771025d9a..c95c5711d8367 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
@@ -7,6 +7,8 @@ load("//libc:libc_build_rules.bzl", "libc_release_library")
package(default_visibility = ["//visibility:public"])
+licenses(["notice"])
+
exports_files(["libc_test_rules.bzl"])
# Smoke test verifying libc_release_library macro functionality.
diff --git a/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
index 361c7c8db6542..51e8424282af0 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
@@ -6,6 +6,8 @@
load("//libc/test:libc_test_rules.bzl", "libc_test")
+package(default_visibility = ["//visibility:public"])
+
licenses(["notice"])
libc_test(
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
index cc3a8d8b4b96a..7802e6f8db6d5 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
@@ -1,5 +1,15 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+# Tests for LLVM libc complex.h functions.
+
load("//libc/test:libc_test_rules.bzl", "libc_test")
+package(default_visibility = ["//visibility:public"])
+
+licenses(["notice"])
+
[
libc_test(
name = func_name + "_test",
|
lntue
approved these changes
Apr 28, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137689) Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137689) Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#137689) Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…vm#137689) Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
…vm#137689) Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses. Add top-level license notice and comment to new BUILD.bazel for complex.h functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses.
Add top-level license notice and comment to new BUILD.bazel for complex.h functions.