Skip to content

[libc][bazel] Make top section of BUILD.bazel files more uniform. #137689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

vonosmas
Copy link
Contributor

Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for complex.h functions.

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
@vonosmas vonosmas requested a review from slackito April 28, 2025 18:59
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Apr 28, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 28, 2025

@llvm/pr-subscribers-libc

Author: Alexey Samsonov (vonosmas)

Changes

Make sure all BUILD.bazel files under llvm-libc are specifying package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for complex.h functions.


Full diff: https://github.com/llvm/llvm-project/pull/137689.diff

3 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel (+2)
  • (modified) utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel (+2)
  • (modified) utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel (+10)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
index ccad771025d9a..c95c5711d8367 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/BUILD.bazel
@@ -7,6 +7,8 @@ load("//libc:libc_build_rules.bzl", "libc_release_library")
 
 package(default_visibility = ["//visibility:public"])
 
+licenses(["notice"])
+
 exports_files(["libc_test_rules.bzl"])
 
 # Smoke test verifying libc_release_library macro functionality.
diff --git a/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
index 361c7c8db6542..51e8424282af0 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/include/BUILD.bazel
@@ -6,6 +6,8 @@
 
 load("//libc/test:libc_test_rules.bzl", "libc_test")
 
+package(default_visibility = ["//visibility:public"])
+
 licenses(["notice"])
 
 libc_test(
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
index cc3a8d8b4b96a..7802e6f8db6d5 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/complex/BUILD.bazel
@@ -1,5 +1,15 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+# Tests for LLVM libc complex.h functions.
+
 load("//libc/test:libc_test_rules.bzl", "libc_test")
 
+package(default_visibility = ["//visibility:public"])
+
+licenses(["notice"])
+
 [
     libc_test(
         name = func_name + "_test",

@vonosmas vonosmas merged commit 882bae9 into llvm:main Apr 28, 2025
12 checks passed
@vonosmas vonosmas deleted the libc-bazel-cleanup branch April 28, 2025 19:40
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…vm#137689)

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…vm#137689)

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…vm#137689)

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
…vm#137689)

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
…vm#137689)

Make sure all BUILD.bazel files under llvm-libc are specifying
package-level default_visibility and licenses.

Add top-level license notice and comment to new BUILD.bazel for
complex.h functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants