Skip to content

[lldb] Provide an unconditional @skip annotation for API tests #137712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/packages/Python/lldbsuite/test/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,10 @@ def skipIf(
)


def skip(bugnumber=None):
return _decorateTest(DecorateMode.Skip, bugnumber=bugnumber)


def _skip_fn_for_android(reason, api_levels, archs):
def impl():
result = lldbplatformutil.match_android_device(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class TestCase(TestBase):
# FIXME: This regressed in 69d5a6662115499198ebfa07a081e98a6ce4b915
# but needs further investigation for what underlying Clang/LLDB bug can't
# handle that code change.
@skipIf
@skip
def test(self):
self.build()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def setUp(self):

# Test hangs due to a kernel bug, see fdfeff0f in the linux kernel for details
@skipIfTargetAndroid(api_levels=list(range(25 + 1)), archs=["aarch64", "arm"])
@skipIf
@skip
def test_watched_var_should_only_hit_when_in_scope(self):
"""Test that a variable watchpoint should only hit when in scope."""
self.build(dictionary=self.d)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test(self):

# This test is meant to be xfailed, but running the test triggers an ASan
# issue, so it must be skipped for now.
@skipIf
@skip
def testExprWholeObject(self):
self.build()
lldbutil.run_to_source_breakpoint(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import socket


@skipIf
@skip
class TestDAP_attachByPortNum(lldbdap_testcase.DAPTestCaseBase):
default_timeout = 20

Expand Down
Loading