Skip to content

[flang][acc] Remove an unused variable #137731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

khaki3
Copy link
Contributor

@khaki3 khaki3 commented Apr 28, 2025

Fixes what #137691 introduced.

@khaki3 khaki3 requested a review from clementval April 28, 2025 23:29
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir openacc labels Apr 28, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 28, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: None (khaki3)

Changes

Fixes what #137691 introduced.


Full diff: https://github.com/llvm/llvm-project/pull/137731.diff

1 Files Affected:

  • (modified) flang/lib/Lower/OpenACC.cpp (+2-3)
diff --git a/flang/lib/Lower/OpenACC.cpp b/flang/lib/Lower/OpenACC.cpp
index 3c42e35afb356..06697b2dbc1d5 100644
--- a/flang/lib/Lower/OpenACC.cpp
+++ b/flang/lib/Lower/OpenACC.cpp
@@ -4131,9 +4131,8 @@ static void genGlobalCtors(Fortran::lower::AbstractConverter &converter,
             },
             [&](const Fortran::parser::Name &name) {
               if (const auto *symbol = name.symbol) {
-                if (const auto *commonBlockDetails =
-                        symbol->detailsIf<
-                            Fortran::semantics::CommonBlockDetails>()) {
+                if (symbol
+                        ->detailsIf<Fortran::semantics::CommonBlockDetails>()) {
                   genCtors(operandLocation, *symbol);
                 } else {
                   TODO(operandLocation,

@llvmbot
Copy link
Member

llvmbot commented Apr 28, 2025

@llvm/pr-subscribers-openacc

Author: None (khaki3)

Changes

Fixes what #137691 introduced.


Full diff: https://github.com/llvm/llvm-project/pull/137731.diff

1 Files Affected:

  • (modified) flang/lib/Lower/OpenACC.cpp (+2-3)
diff --git a/flang/lib/Lower/OpenACC.cpp b/flang/lib/Lower/OpenACC.cpp
index 3c42e35afb356..06697b2dbc1d5 100644
--- a/flang/lib/Lower/OpenACC.cpp
+++ b/flang/lib/Lower/OpenACC.cpp
@@ -4131,9 +4131,8 @@ static void genGlobalCtors(Fortran::lower::AbstractConverter &converter,
             },
             [&](const Fortran::parser::Name &name) {
               if (const auto *symbol = name.symbol) {
-                if (const auto *commonBlockDetails =
-                        symbol->detailsIf<
-                            Fortran::semantics::CommonBlockDetails>()) {
+                if (symbol
+                        ->detailsIf<Fortran::semantics::CommonBlockDetails>()) {
                   genCtors(operandLocation, *symbol);
                 } else {
                   TODO(operandLocation,

@khaki3 khaki3 merged commit b95cc91 into llvm:main Apr 28, 2025
10 of 14 checks passed
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang Flang issues not falling into any other category openacc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants