Skip to content

[X86] Remove LLD command in LIT test #137794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

fzou1
Copy link
Contributor

@fzou1 fzou1 commented Apr 29, 2025

The test introduced in #136660, may be failed as ld.lld command not found.

@llvmbot
Copy link
Member

llvmbot commented Apr 29, 2025

@llvm/pr-subscribers-backend-x86

Author: Feng Zou (fzou1)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/137794.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/X86/apx/tls.ll (-6)
diff --git a/llvm/test/CodeGen/X86/apx/tls.ll b/llvm/test/CodeGen/X86/apx/tls.ll
index 736e843dc1a26..1149fe832802e 100644
--- a/llvm/test/CodeGen/X86/apx/tls.ll
+++ b/llvm/test/CodeGen/X86/apx/tls.ll
@@ -5,14 +5,10 @@
 ; RUN: llc -mattr=+egpr %s -mtriple=x86_64 -filetype=obj -o %t.o -x86-enable-apx-for-relocation=true
 ; RUN: llvm-objdump --no-print-imm-hex -dr %t.o | FileCheck %s --check-prefix=GOTTPOFF_APXRELAX
 ; RUN: echo '.tbss; .globl b,c,d,e,f,g,h,i,j; b: .zero 4;c: .zero 4;d: .zero 4;e: .zero 4;f: .zero 4;g: .zero 4;h: .zero 4;i: .zero 4;j: .zero 4' | llvm-mc -filetype=obj -triple=x86_64 - -o %t1.o
-; RUN: ld.lld  %t.o %t1.o -o %t.so
-; RUN: llvm-objdump --no-print-imm-hex -dr %t.so | FileCheck %s --check-prefix=GOTTPOFF_LD_APXRELAX
 
 ; RUN: llc -mattr=+egpr %s -mtriple=x86_64 -filetype=obj -o %t.o
 ; RUN: llvm-objdump --no-print-imm-hex -dr %t.o | FileCheck %s --check-prefix=GOTTPOFF_NOAPXRELAX
 ; RUN: echo '.tbss; .globl b,c,d,e,f,g,h,i,j; b: .zero 4;c: .zero 4;d: .zero 4;e: .zero 4;f: .zero 4;g: .zero 4;h: .zero 4;i: .zero 4;j: .zero 4' | llvm-mc -filetype=obj -triple=x86_64 - -o %t1.o
-; RUN: ld.lld  %t.o %t1.o -o %t.so
-; RUN: llvm-objdump --no-print-imm-hex -dr %t.so | FileCheck %s --check-prefix=GOTTPOFF_LD_NOAPXRELAX
 
 
 ; TLSDESC: d5 18 89 c0       movq %rax, %r16
@@ -21,11 +17,9 @@
 
 ; GOTTPOFF_APXRELAX: d5 48 8b 05 00 00 00 00       movq (%rip), %r16
 ; GOTTPOFF_APXRELAX-NEXT: R_X86_64_CODE_4_GOTTPOFF j-0x4
-; GOTTPOFF_LD_APXRELAX: d5 18 c7 c0 fc ff ff ff       movq $-4, %r16
 
 ; GOTTPOFF_NOAPXRELAX: 48 8b 1d 00 00 00 00       movq (%rip), %rbx
 ; GOTTPOFF_NOAPXRELAX-NEXT: R_X86_64_GOTTPOFF j-0x4
-; GOTTPOFF_LD_NOAPXRELAX: 48 c7 c3 fc ff ff ff       movq $-4, %rbx
 
 @a = thread_local global i32 0, align 4
 @b = external thread_local global i32, align 4

@fzou1
Copy link
Contributor Author

fzou1 commented Apr 29, 2025

Test is failed as ld.lld command not found: https://lab.llvm.org/buildbot/#/builders/185/builds/17441

@fzou1 fzou1 changed the title [X86] Remove LLD command in LIT test introduced in #136660 [X86] Remove LLD command in LIT test Apr 29, 2025
Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fzou1 fzou1 merged commit f02c93d into llvm:main Apr 29, 2025
13 checks passed
@fzou1 fzou1 deleted the remove_lld_in_x86_lit_test branch April 29, 2025 13:27
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
The test introduced in llvm#136660, may be failed as ld.lld command not
found.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
The test introduced in llvm#136660, may be failed as ld.lld command not
found.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
The test introduced in llvm#136660, may be failed as ld.lld command not
found.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
The test introduced in llvm#136660, may be failed as ld.lld command not
found.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
The test introduced in llvm#136660, may be failed as ld.lld command not
found.
fzou1 added a commit to fzou1/llvm-project that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants