[RISCV][NFC] Remove duplicate extensions from tt-ascalon-d8 CPU #137865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Min-Yih Hsu (mshockwave) ChangesSscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a test to check Sscofpmf. This is effectively an NFC. This is found by #137864 Full diff: https://github.com/llvm/llvm-project/pull/137865.diff 2 Files Affected:
diff --git a/clang/test/Driver/riscv-cpus.c b/clang/test/Driver/riscv-cpus.c
index bb3a9d38be673..6fa401203361e 100644
--- a/clang/test/Driver/riscv-cpus.c
+++ b/clang/test/Driver/riscv-cpus.c
@@ -251,6 +251,7 @@
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl256b"
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl32b"
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl64b"
+// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+sscofpmf"
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svinval"
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svnapot"
// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svpbmt"
diff --git a/llvm/lib/Target/RISCV/RISCVProcessors.td b/llvm/lib/Target/RISCV/RISCVProcessors.td
index 1ad94228bcbaa..822c25a4e1130 100644
--- a/llvm/lib/Target/RISCV/RISCVProcessors.td
+++ b/llvm/lib/Target/RISCV/RISCVProcessors.td
@@ -480,11 +480,9 @@ def TENSTORRENT_ASCALON_D8 : RISCVProcessorModel<"tt-ascalon-d8",
!listconcat(RVA23S64Features,
[FeatureStdExtSmaia,
FeatureStdExtSsaia,
- FeatureStdExtSscofpmf,
FeatureStdExtSsstrict,
FeatureStdExtZfbfmin,
FeatureStdExtZfh,
- FeatureStdExtZicsr,
FeatureStdExtZvbc,
FeatureStdExtZvfbfmin,
FeatureStdExtZvfbfwma,
|
|
If the |
mshockwave
changed the title
Agree. It's updated now. |
lenary
approved these changes
Apr 29, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…#137865) Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…#137865) Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…#137865) Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…#137865) Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
…#137865) Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.
This is found by #137864