[PPC][NFC] Remove duplicate processor feature from pwr9/10/11 and future #137903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-powerpc Author: Min-Yih Hsu (mshockwave) ChangesThe new TableGen warning introduced in 951292b shows the following warnings: Full diff: https://github.com/llvm/llvm-project/pull/137903.diff 1 Files Affected:
diff --git a/llvm/lib/Target/PowerPC/PPC.td b/llvm/lib/Target/PowerPC/PPC.td
index 39da428461393..6b058d1a74772 100644
--- a/llvm/lib/Target/PowerPC/PPC.td
+++ b/llvm/lib/Target/PowerPC/PPC.td
@@ -435,8 +435,7 @@ def ProcessorFeatures {
FeatureP9Vector,
FeaturePPCPreRASched,
FeaturePPCPostRASched,
- FeatureISA3_0,
- FeaturePredictableSelectIsExpensive
+ FeatureISA3_0
];
// Some features are unique to Power9 and there is no reason to assume
|
jroelofs
reviewed
Apr 30, 2025
| @@ -435,8 +435,7 @@ def ProcessorFeatures { | |||
| FeatureP9Vector, | |||
| FeaturePPCPreRASched, | |||
| FeaturePPCPostRASched, | |||
| FeatureISA3_0, | |||
| FeaturePredictableSelectIsExpensive | |||
| FeatureISA3_0 | |||
There was a problem hiding this comment.
Might be a bit of a bigger refactor than you're looking to do here, but the AArch64 backend is a much better model for this: ISA features, and Tune features are separated out into parallel lists.
There was a problem hiding this comment.
Agree, RISCV is doing that as well. Though I believe doing such separation for PPC is out of the scope of this patch.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…ure (llvm#137903) The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor future contains duplicate feature 'predictable-select-expensive' warning: Processor pwr10 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr11 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr9 contains duplicate feature 'predictable-select-expensive' ```
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…ure (llvm#137903) The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor future contains duplicate feature 'predictable-select-expensive' warning: Processor pwr10 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr11 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr9 contains duplicate feature 'predictable-select-expensive' ```
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…ure (llvm#137903) The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor future contains duplicate feature 'predictable-select-expensive' warning: Processor pwr10 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr11 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr9 contains duplicate feature 'predictable-select-expensive' ```
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…ure (llvm#137903) The new TableGen warning introduced in llvm@951292b shows the following warnings: ``` warning: Processor future contains duplicate feature 'predictable-select-expensive' warning: Processor pwr10 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr11 contains duplicate feature 'predictable-select-expensive' warning: Processor pwr9 contains duplicate feature 'predictable-select-expensive' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TableGen warning introduced in 951292b shows the following warnings: