[llvm][test] Change an XFAIL into a more correct REQUIRES #137942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
DavidSpickett
changed the title
DavidSpickett
approved these changes
Apr 30, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target. Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this test is about executing x86_64 code with "lli", we should only try to do it if we actually execute on an x86_64 target. So instead of XFAILing individual architectures that can't execute it, instead change this into requiring an x86_64 target.
Also generalize the target triple form used; don't assume that the vendor field is set to "pc" - many mingw toolchains use the vendor field set to "w64".