Skip to content

[clang] Make -ftime-report and -ftime-report-json honor -info-output-file #138035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

alanzhao1
Copy link
Contributor

This way, the output of -ftime-report and -ftime-report-json can be redirected to a specific file rather than just stderr.

…put-file

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
@alanzhao1 alanzhao1 requested a review from aeubanks April 30, 2025 21:41
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Apr 30, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 30, 2025

@llvm/pr-subscribers-clang

Author: Alan Zhao (alanzhao1)

Changes

This way, the output of -ftime-report and -ftime-report-json can be redirected to a specific file rather than just stderr.


Full diff: https://github.com/llvm/llvm-project/pull/138035.diff

2 Files Affected:

  • (modified) clang/test/Misc/time-passes.c (+8)
  • (modified) clang/tools/driver/cc1_main.cpp (+5-4)
diff --git a/clang/test/Misc/time-passes.c b/clang/test/Misc/time-passes.c
index 35b5e1634ee73..370f52e4904fe 100644
--- a/clang/test/Misc/time-passes.c
+++ b/clang/test/Misc/time-passes.c
@@ -3,6 +3,10 @@
 // RUN:     -ftime-report %s -o /dev/null 2>&1 | \
 // RUN:     FileCheck %s --check-prefixes=TIME,NPM
 // RUN: %clang_cc1 -emit-obj -O1 \
+// RUN:     -ftime-report %s -o /dev/null \
+// RUN:     -mllvm -info-output-file=%t
+// RUN: cat %t | FileCheck %s --check-prefixes=TIME,NPM
+// RUN: %clang_cc1 -emit-obj -O1 \
 // RUN:     -ftime-report=per-pass %s -o /dev/null 2>&1 | \
 // RUN:     FileCheck %s --check-prefixes=TIME,NPM
 // RUN: %clang_cc1 -emit-obj -O1 \
@@ -11,6 +15,10 @@
 // RUN: %clang_cc1 -emit-obj -O1 \
 // RUN:     -ftime-report-json %s -o /dev/null 2>&1 | \
 // RUN:     FileCheck %s --check-prefixes=JSON
+// RUN: %clang_cc1 -emit-obj -O1 \
+// RUN:     -ftime-report-json %s -o /dev/null \
+// RUN:     -mllvm -info-output-file=%t
+// RUN: cat %t | FileCheck %s --check-prefixes=JSON
 
 // TIME: Pass execution timing report
 // TIME: Total Execution Time:
diff --git a/clang/tools/driver/cc1_main.cpp b/clang/tools/driver/cc1_main.cpp
index 1e79e78fdea62..dd53712bcfc96 100644
--- a/clang/tools/driver/cc1_main.cpp
+++ b/clang/tools/driver/cc1_main.cpp
@@ -296,12 +296,13 @@ int cc1_main(ArrayRef<const char *> Argv, const char *Argv0, void *MainAddr) {
 
   // If any timers were active but haven't been destroyed yet, print their
   // results now.  This happens in -disable-free mode.
+  std::unique_ptr<raw_ostream> IOFile = llvm::CreateInfoOutputFile();
   if (Clang->getCodeGenOpts().TimePassesJson) {
-    llvm::errs() << "{\n";
-    llvm::TimerGroup::printAllJSONValues(llvm::errs(), "");
-    llvm::errs() << "\n}\n";
+    *IOFile << "{\n";
+    llvm::TimerGroup::printAllJSONValues(*IOFile, "");
+    *IOFile << "\n}\n";
   } else {
-    llvm::TimerGroup::printAll(llvm::errs());
+    llvm::TimerGroup::printAll(*IOFile);
   }
   llvm::TimerGroup::clearAll();
 

@alanzhao1 alanzhao1 merged commit 69327c1 into llvm:main Apr 30, 2025
8 of 11 checks passed
@alanzhao1 alanzhao1 deleted the feature/time-report-iofile branch April 30, 2025 21:48
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…tput-file` (llvm#138035)

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…tput-file` (llvm#138035)

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…tput-file` (llvm#138035)

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
…tput-file` (llvm#138035)

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
…tput-file` (llvm#138035)

This way, the output of `-ftime-report` and `-ftime-report-json` can be
redirected to a specific file rather than just stderr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants