-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang][NFC] Fix some clang-format mistakes #138036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
Ignoring clang-format CI result |
You can test this locally with the following command:git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/CodeGen/CGCall.cpp View the diff from clang-format here.diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp
index b5a7217dd..83b0e8e96 100644
--- a/clang/lib/CodeGen/CGCall.cpp
+++ b/clang/lib/CodeGen/CGCall.cpp
@@ -3520,7 +3520,8 @@ static llvm::Value *tryEmitFusedAutoreleaseOfResult(CodeGenFunction &CGF,
// Look for:
// %generator = call i8* @objc_retain(i8* %originalResult)
// or
- // %generator = call i8* @objc_retainAutoreleasedReturnValue(i8* %originalResult)
+ // %generator = call i8* @objc_retainAutoreleasedReturnValue(i8*
+ // %originalResult)
llvm::CallInst *call = dyn_cast<llvm::CallInst>(generator);
if (!call)
return nullptr;
@@ -3996,7 +3997,7 @@ void CodeGenFunction::EmitFunctionEpilog(const CGFunctionInfo &FI,
RV = SI->getValueOperand();
SI->eraseFromParent();
- // Otherwise, we have to do a simple load.
+ // Otherwise, we have to do a simple load.
} else {
RV = Builder.CreateLoad(ReturnValue);
}
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Nick Sarnie (sarnex) ChangesFixes for #138000 Full diff: https://github.com/llvm/llvm-project/pull/138036.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp
index 83b0e8e965770..b5a7217dd3e56 100644
--- a/clang/lib/CodeGen/CGCall.cpp
+++ b/clang/lib/CodeGen/CGCall.cpp
@@ -3520,8 +3520,7 @@ static llvm::Value *tryEmitFusedAutoreleaseOfResult(CodeGenFunction &CGF,
// Look for:
// %generator = call i8* @objc_retain(i8* %originalResult)
// or
- // %generator = call i8* @objc_retainAutoreleasedReturnValue(i8*
- // %originalResult)
+ // %generator = call i8* @objc_retainAutoreleasedReturnValue(i8* %originalResult)
llvm::CallInst *call = dyn_cast<llvm::CallInst>(generator);
if (!call)
return nullptr;
@@ -3997,7 +3996,7 @@ void CodeGenFunction::EmitFunctionEpilog(const CGFunctionInfo &FI,
RV = SI->getValueOperand();
SI->eraseFromParent();
- // Otherwise, we have to do a simple load.
+ // Otherwise, we have to do a simple load.
} else {
RV = Builder.CreateLoad(ReturnValue);
}
|
@@ -3997,7 +3996,7 @@ void CodeGenFunction::EmitFunctionEpilog(const CGFunctionInfo &FI, | |||
RV = SI->getValueOperand(); | |||
SI->eraseFromParent(); | |||
|
|||
// Otherwise, we have to do a simple load. | |||
// Otherwise, we have to do a simple load. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pointed out this one specifically, but I think the same thing happened in a few other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go through and check, thanks
Fixes for llvm#138000 Signed-off-by: Sarnie, Nick <[email protected]>
Fixes for llvm#138000 Signed-off-by: Sarnie, Nick <[email protected]>
Fixes for llvm#138000 Signed-off-by: Sarnie, Nick <[email protected]>
More fixes based on #138036 --------- Signed-off-by: Sarnie, Nick <[email protected]>
…(#138342) More fixes based on llvm/llvm-project#138036 --------- Signed-off-by: Sarnie, Nick <[email protected]>
Fixes for llvm#138000 Signed-off-by: Sarnie, Nick <[email protected]>
Fixes for #138000