[libclang/python] Remove compatibility workaround for briefComment #138135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) ChangesFull diff: https://github.com/llvm/llvm-project/pull/138135.diff 1 Files Affected:
diff --git a/clang/bindings/python/clang/cindex.py b/clang/bindings/python/clang/cindex.py
index e4a731b1d57fa..2b0a1db04821e 100644
--- a/clang/bindings/python/clang/cindex.py
+++ b/clang/bindings/python/clang/cindex.py
@@ -2980,11 +2980,7 @@ def availability(self):
@property
def briefComment(self):
- if conf.function_exists("clang_getCompletionBriefComment"):
- return _CXString.from_result(
- conf.lib.clang_getCompletionBriefComment(self.obj)
- )
- return ""
+ return _CXString.from_result(conf.lib.clang_getCompletionBriefComment(self.obj))
def __repr__(self):
return (
@@ -4264,14 +4260,6 @@ def get_cindex_library(self) -> CDLL:
return library
- def function_exists(self, name: str) -> bool:
- try:
- getattr(self.lib, name)
- except AttributeError:
- return False
-
- return True
-
conf = Config()
|
Endilll
approved these changes
May 1, 2025
|
For the record, this was discussed in #138132 (comment) |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/17007 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#138135) Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#138135) Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#138135) Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…lvm#138135) Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
…lvm#138135) Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a workaround that made cindex.py from LLVM 3.2 work with older libclang.so versions