[clang] Complete the revert of 1a14ef1 #138341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.
llvmbot
added
clang
|
@zahiraam missed this while reverting :-O |
|
@llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) ChangesWhen merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor. Full diff: https://github.com/llvm/llvm-project/pull/138341.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/LangOptions.h b/clang/include/clang/Basic/LangOptions.h
index c3b6264e62659..1bfc0d8e88556 100644
--- a/clang/include/clang/Basic/LangOptions.h
+++ b/clang/include/clang/Basic/LangOptions.h
@@ -76,8 +76,6 @@ class LangOptionsBase {
using RoundingMode = llvm::RoundingMode;
using CFBranchLabelSchemeKind = clang::CFBranchLabelSchemeKind;
- LangOptionsBase() = default;
-
enum GCMode { NonGC, GCOnly, HybridGC };
enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq };
|
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging the fix for FEM_Indeterminate I reverted the follow on warning fixes, but misread this diff and retained the explicitly defaulted constructor.