[clang] Document -fstrict-flex-arrays option #138388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: None (serge-sans-paille) ChangesFix #138185 Full diff: https://github.com/llvm/llvm-project/pull/138388.diff 1 Files Affected:
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 2946ffaa28da0..5ceba7e3bf4c7 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group<f_Grou
Visibility<[ClangOption, CC1Option]>,
NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>,
- HelpText<"Enable optimizations based on the strict definition of flexible arrays">,
+ HelpText<"Enable optimizations based on the strict definition of flexible arrays. "
+ "If ``<n>`` is equal to 0, any trailing array member is considered a flexible array. "
+ "If ``<n>`` is equal to 1, trailing array members of size 0, 1 and undefined are considered flexible arrays. "
+ "If ``<n>`` is equal to 3, only trailing array members of undefined size are considered flexible arrays.">,
MarshallingInfoEnum<LangOpts<"StrictFlexArraysLevel">, "Default">;
defm apple_pragma_pack : BoolFOption<"apple-pragma-pack",
LangOpts<"ApplePragmaPack">, DefaultFalse,
|
|
@zygoloid this restores (and hopefully improves) the original documentation. The values and behavior are obviously the same as gcc. I don't have a strong opinion on value aliases. |
zygoloid
reviewed
May 3, 2025
| @@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">, Group<f_Grou | |||
| Visibility<[ClangOption, CC1Option]>, | |||
| NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, | |||
| NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "IncompleteOnly"]>, | |||
| HelpText<"Enable optimizations based on the strict definition of flexible arrays">, | |||
| HelpText<"Enable optimizations based on the strict definition of flexible arrays. " | |||
There was a problem hiding this comment.
This is much too long to include in the --help output. Maybe this could be specified as DocBrief instead soon it goes into the command-line reference but not --help
There was a problem hiding this comment.
Done. I wasn't aware of DocBreef, that's indeed much better like this.
| HelpText<"Enable optimizations based on the strict definition of flexible arrays. " | ||
| "If ``<n>`` is equal to 0, any trailing array member is considered a flexible array. " | ||
| "If ``<n>`` is equal to 1, trailing array members of size 0, 1 and undefined are considered flexible arrays. " | ||
| "If ``<n>`` is equal to 3, only trailing array members of undefined size are considered flexible arrays.">, |
There was a problem hiding this comment.
oopsie. Fixed
serge-sans-paille
force-pushed
the
bug/138185
branch
from
fae4db4 to
39cf81c
Compare
|
Thank you for the quick turnaround on the documentation! |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #138185