[AMDGPU] Use Reg32Types for move-immediate patterns #138422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just avoids having another copy of the list of valid 32-bit pointer types.
|
@llvm/pr-subscribers-backend-amdgpu Author: Jay Foad (jayfoad) ChangesThis just avoids having another copy of the list of valid 32-bit pointer Full diff: https://github.com/llvm/llvm-project/pull/138422.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index f5c6d47369781..dea20e2d84d7b 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -2270,16 +2270,18 @@ def : GCNPat <
// FIXME: Remove VGPRImm. Should be inferrable from register bank.
-foreach vt = [i32, p3, p5, p6, p2] in {
- def : GCNPat <
- (VGPRImm<(vt imm)>:$imm),
- (V_MOV_B32_e32 imm:$imm)
- >;
+foreach vt = Reg32Types.types in {
+ if !and(!not(vt.isVector), !not(vt.isFP)) then {
+ def : GCNPat <
+ (VGPRImm<(vt imm)>:$imm),
+ (V_MOV_B32_e32 imm:$imm)
+ >;
- def : GCNPat <
- (vt imm:$imm),
- (S_MOV_B32 imm:$imm)
- >;
+ def : GCNPat <
+ (vt imm:$imm),
+ (S_MOV_B32 imm:$imm)
+ >;
+ }
}
// FIXME: The register bank of the frame index should depend on the
|
arsenm
approved these changes
May 3, 2025
| (V_MOV_B32_e32 imm:$imm) | ||
| >; | ||
| foreach vt = Reg32Types.types in { | ||
| if !and(!not(vt.isVector), !not(vt.isFP)) then { |
There was a problem hiding this comment.
Probably should have a more direct way to specify integer or pointer
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This just avoids having another copy of the list of valid 32-bit pointer types.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This just avoids having another copy of the list of valid 32-bit pointer types.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This just avoids having another copy of the list of valid 32-bit pointer types.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This just avoids having another copy of the list of valid 32-bit pointer types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just avoids having another copy of the list of valid 32-bit pointer
types.