qsort_r.h: qsort_r() is POSIX now.

[enh-google]

No description provided.

[llvmbot]

@llvm/pr-subscribers-libc

Author: None (enh-google)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/138545.diff

1 Files Affected:

• (modified) libc/src/stdlib/qsort_r.h (+3-4)

diff --git a/libc/src/stdlib/qsort_r.h b/libc/src/stdlib/qsort_r.h
index 51a459c3f7633..b0d8c57c75c78 100644
--- a/libc/src/stdlib/qsort_r.h
+++ b/libc/src/stdlib/qsort_r.h
@@ -14,10 +14,9 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-// This qsort_r uses the glibc argument ordering instead of the BSD argument
-// ordering (which puts arg before the function pointer). Putting arg after the
-// function pointer more closely matches the ordering for qsort_s, which is the
-// standardized equivalent of qsort_r.
+// This qsort_r uses the POSIX 1003.1-2024 argument ordering instead of the
+// historical BSD argument ordering (which put arg before the function pointer).
+// https://www.austingroupbugs.net/view.php?id=900
 
 void qsort_r(void *array, size_t array_size, size_t elem_size,
              int (*compare)(const void *, const void *, void *), void *arg);

[SchrodingerZhu]

@enh-google maybe headergen config also needs to be updated.

[michaelrj-google]

LGTM

[enh-google]

@enh-google maybe headergen config also needs to be updated.

github search doesn't find anything with that name?

[SchrodingerZhu]

llvm-project/libc/include/stdlib.yaml

Line 161 in 02e0a95

- GNUExtensions

[enh-google]

llvm-project/libc/include/stdlib.yaml

Line 161 in 02e0a95

- GNUExtensions

ah, i see. i've sent #138572 for that.