llvm][docs] Use default checkout location in test suite guide #139264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step 2 tells you to checkout "llvm-test-suite" to "test-suite", but I don't see a particular reason to use a non-default path. If you're following the instructions exactly, it all works, but if you autopilot that step it is surprising later when things do not work. It's not hard for an individual to fix later, but we should suggest the least surprising thing where we can.
tarunprabhu
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 tells you to checkout "llvm-test-suite" to "test-suite", but I don't see a particular reason to use a non-default path.
If you're following the instructions exactly, it all works, but if you autopilot that step it is surprising later when things do not work.
It's not hard for an individual to fix later, but we should suggest the least surprising thing where we can.