Skip to content

[FuzzMutate] Prevent UB caused by parameter ABI attributes #139737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

mgcarrasco
Copy link
Contributor

This PR prevents the IRMutator from incorrectly calling functions that have ABI attributes, otherwise the mutations introduce UB.

@jmmartinez jmmartinez requested a review from DataCorrupted May 13, 2025 14:17
We make those cases unsupported as it happens now for functions accepting metadata or token types.
@mgcarrasco mgcarrasco force-pushed the pr/ir-mutator-abi-attr branch from 317e2ee to 728c8bc Compare June 5, 2025 13:38
@mgcarrasco
Copy link
Contributor Author

mgcarrasco commented Jun 5, 2025

@DataCorrupted Thanks for the feedback. The PR has been updated addressing the comment.

@DataCorrupted DataCorrupted merged commit 8a386fe into llvm:main Jun 5, 2025
11 checks passed
rorth pushed a commit to rorth/llvm-project that referenced this pull request Jun 11, 2025
This PR prevents the IRMutator from incorrectly calling functions that
have ABI attributes, otherwise the mutations introduce UB.
DhruvSrivastavaX pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this pull request Jun 12, 2025
This PR prevents the IRMutator from incorrectly calling functions that
have ABI attributes, otherwise the mutations introduce UB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants