[lldb] Extend information for failed connection for gdb server #139916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: None (ita-sc) ChangesBefore: After the patch: Full diff: https://github.com/llvm/llvm-project/pull/139916.diff 1 Files Affected:
diff --git a/lldb/source/Host/common/TCPSocket.cpp b/lldb/source/Host/common/TCPSocket.cpp
index d3282ab58b818..4148ad67b04bf 100644
--- a/lldb/source/Host/common/TCPSocket.cpp
+++ b/lldb/source/Host/common/TCPSocket.cpp
@@ -169,7 +169,8 @@ Status TCPSocket::Connect(llvm::StringRef name) {
return error;
}
- error = Status::FromErrorString("Failed to connect port");
+ error = Status::FromErrorStringWithFormatv("Failed to connect {0}:{1}",
+ host_port->hostname, host_port->port);
return error;
}
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
JDevlieghere
approved these changes
May 14, 2025
Before: ``` (lldb) r error: connect remote failed (Failed to connect port) error: Failed to connect port ``` After the patch: ``` (lldb) r error: connect remote failed (Failed to connect to localhost:47140) error: Failed to connect to localhost:47140 ```
|
Thanks for review. |
DavidSpickett
changed the title
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
…139916) Before: ``` (lldb) r error: connect remote failed (Failed to connect port) error: Failed to connect port ``` After the patch: ``` (lldb) r error: connect remote failed (Failed to connect localhost:47140) error: Failed to connect localhost:47140 ```
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
…139916) Before: ``` (lldb) r error: connect remote failed (Failed to connect port) error: Failed to connect port ``` After the patch: ``` (lldb) r error: connect remote failed (Failed to connect localhost:47140) error: Failed to connect localhost:47140 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After the patch: