-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[MLIR][NVVM] Add inline_ptx
op
#139923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR][NVVM] Add inline_ptx
op
#139923
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,6 +236,76 @@ foreach index = !range(0, 32) in { | |
def NVVM_EnvReg # index # Op : NVVM_SpecialRegisterOp<"read.ptx.sreg.envreg" # index>; | ||
} | ||
|
||
//===----------------------------------------------------------------------===// | ||
// Inline PTX op definition | ||
//===----------------------------------------------------------------------===// | ||
|
||
def NVVM_InlinePtxOp : NVVM_Op<"inline_ptx", | ||
[DeclareOpInterfaceMethods<BasicPtxBuilderOpInterface>, | ||
AttrSizedOperandSegments]> | ||
{ | ||
let summary = "Inline PTX Op"; | ||
let description = [{This op allows using PTX directly within the NVVM | ||
dialect, while greatly simplifying llvm.inline_asm generation. It | ||
automatically handles register size selection and sets the correct | ||
read/write access for each operand. The operation leverages the | ||
`BasicPtxBuilderInterface` to abstract away low-level details of | ||
PTX assembly formatting. | ||
|
||
The `predicate` attribute is used to specify a predicate for the | ||
PTX instruction. | ||
|
||
Example 1: Read-only Parameters | ||
```mlir | ||
nvvm.inline_ptx "mbarrier.init.b64 [$0], $1;" (%barrier_gen, %count) : !llvm.ptr, i32 | ||
|
||
// Lowers to: | ||
llvm.inline_asm has_side_effects asm_dialect = att | ||
"mbarrier.init.b64 [$0], $1;", "l,r" %arg0, %arg2 : (!llvm.ptr, i32) -> () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
What do you mean by clean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I meant the mlir version exactly matches the unit-test but the lowered version still refers to (!llvm.ptr, i32) instead of "l, r" |
||
``` | ||
|
||
Example 2: Read-only and Write-only Parameters | ||
```mlir | ||
%0 = nvvm.inline_ptx "ex2.approx.ftz.f32 $0, $1;" (%input) : f32 -> f32 | ||
|
||
// Lowers to: | ||
%0 = llvm.inline_asm has_side_effects asm_dialect = att | ||
"ex2.approx.ftz.f32 $0, $1;", "=f,f" %arg0 : (f32) -> f32 | ||
``` | ||
|
||
Example 3: Predicate Usage | ||
```mlir | ||
nvvm.inline_ptx "mbarrier.init.b64 [$0], $1;" (%barrier_gen, %count), | ||
predicate = %pred : !llvm.ptr, i32, i1 | ||
|
||
// Lowers to: | ||
llvm.inline_asm has_side_effects asm_dialect = att | ||
"@$2 mbarrier.init.b64 [$0], $1;", "l,r,b" %arg0, %arg2, %arg3 | ||
: (!llvm.ptr, i32, i1) -> () | ||
``` | ||
}]; | ||
|
||
let arguments = (ins Variadic<AnyType>:$readOnlyArgs, | ||
StrAttr:$ptxCode, | ||
PtxPredicate:$predicate); | ||
|
||
let results = (outs Variadic<AnyType>:$writeOnlyArgs); | ||
|
||
let assemblyFormat = [{ | ||
$ptxCode `(` $readOnlyArgs `)` | ||
(`,` `predicate` `=` $predicate^)? attr-dict | ||
`:` type(operands) | ||
(`->` type($writeOnlyArgs)^)? | ||
}]; | ||
|
||
let extraClassDefinition = [{ | ||
std::string $cppClass::getPtx() { | ||
StringRef ptxInstStr = getPtxCode(); | ||
return std::string(ptxInstStr.data()); | ||
} | ||
}]; | ||
} | ||
|
||
//===----------------------------------------------------------------------===// | ||
// NVVM approximate op definitions | ||
//===----------------------------------------------------------------------===// | ||
|
Uh oh!
There was an error while loading. Please reload this page.