Skip to content

[AMDGPU][Docs] Correct Radeon Pro 5600M ISA #140041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

frederik-h
Copy link
Contributor

As observed by LLVM Discord user "buck", the Radeon Pro 5600M is gfx1011 and the entry in the gfx1010 category was probably meant to be Radeon RX 5600M which indeed is gfx1010.

As observed by LLVM Discord user "buck", the Radeon Pro 5600M is
gfx1011 and the entry in the gfx1010 category was probably meant
to be Radeon RX 5600M which indeed is gfx1010.
@llvmbot
Copy link
Member

llvmbot commented May 15, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Frederik Harwath (frederik-h)

Changes

As observed by LLVM Discord user "buck", the Radeon Pro 5600M is gfx1011 and the entry in the gfx1010 category was probably meant to be Radeon RX 5600M which indeed is gfx1010.


Full diff: https://github.com/llvm/llvm-project/pull/140041.diff

1 Files Affected:

  • (modified) llvm/docs/AMDGPUUsage.rst (+5-5)
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst
index d1535960a0257..55b168b20d0e7 100644
--- a/llvm/docs/AMDGPUUsage.rst
+++ b/llvm/docs/AMDGPUUsage.rst
@@ -394,12 +394,12 @@ Every processor supports every OS ABI (see :ref:`amdgpu-os`) with the following
 
      **GCN GFX10.1 (RDNA 1)** [AMD-GCN-GFX10-RDNA1]_
      -----------------------------------------------------------------------------------------------------------------------
-     ``gfx1010``                 ``amdgcn``   dGPU  - cumode          - Absolute      - *rocm-amdhsa* - Radeon RX 5700
-                                                    - wavefrontsize64   flat          - *pal-amdhsa*  - Radeon RX 5700 XT
-                                                    - xnack             scratch       - *pal-amdpal*  - Radeon Pro 5600 XT
-                                                                                                      - Radeon Pro 5600M
+     ``gfx1010``                 ``amdgcn``   dGPU  - cumode          - Absolute      - *rocm-amdhsa* - Radeon Pro 5600 XT
+                                                    - wavefrontsize64   flat          - *pal-amdhsa*  - Radeon RX 5600M
+                                                    - xnack             scratch       - *pal-amdpal*  - Radeon RX 5700
+                                                                                                      - Radeon RX 5700 XT
      ``gfx1011``                 ``amdgcn``   dGPU  - cumode                          - *rocm-amdhsa* - Radeon Pro V520
-                                                    - wavefrontsize64 - Absolute      - *pal-amdhsa*
+                                                    - wavefrontsize64 - Absolute      - *pal-amdhsa*  - Radeon Pro 5600M
                                                     - xnack             flat          - *pal-amdpal*
                                                                         scratch
      ``gfx1012``                 ``amdgcn``   dGPU  - cumode          - Absolute      - *rocm-amdhsa* - Radeon RX 5500

@frederik-h
Copy link
Contributor Author

Compare with the output of the "Radeon GPU analyzer" which has a comprehensive list matching product names to ISAs:

$ ~/rga-2.12.0.56/rga -s bin -l | grep -C1 "Radeon Pro 5600M"
gfx1011 (RDNA)
        AMD Radeon Pro 5600M
        AMD Radeon Pro V520

and

$ ~/rga-2.12.0.56/rga -s bin -l | grep -C8 "Radeon RX 5600M"
        AMD Instinct(TM) MI300X
        AMD Instinct(TM) MI300XHF
gfx1010 (RDNA)
        AMD Radeon Pro 5700 XT
        AMD Radeon Pro W5700
        AMD Radeon Pro W5700X
        AMD Radeon RX 5600 OEM
        AMD Radeon RX 5600 XT
        AMD Radeon RX 5600M
        AMD Radeon RX 5700
        AMD Radeon RX 5700 XT
        AMD Radeon RX 5700 XT 50th Anniversary
        AMD Radeon RX 5700B
        AMD Radeon RX 5700M
gfx1011 (RDNA)
        AMD Radeon Pro 5600M
        AMD Radeon Pro V520

@jayfoad
Copy link
Contributor

jayfoad commented May 15, 2025

Compare with the output of the "Radeon GPU analyzer" which has a comprehensive list matching product names to ISAs:

Similar info is maintained here: https://github.com/pciutils/pciids/blob/master/pci.ids

@frederik-h frederik-h requested review from t-tye, kzhuravl and arsenm May 15, 2025 11:28
@frederik-h frederik-h merged commit 124e547 into llvm:main May 15, 2025
12 checks passed
@frederik-h frederik-h deleted the correct-radeon-pro-5600M-isa branch May 15, 2025 12:03
TIFitis pushed a commit to TIFitis/llvm-project that referenced this pull request May 19, 2025
As observed by LLVM Discord user "buck", the Radeon Pro 5600M is gfx1011
and the entry in the gfx1010 category was probably meant to be Radeon RX
5600M which indeed is gfx1010.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants