Skip to content

[llvm] Fix test breakage in Vectorize/VPlanVerifierTest.cpp #140079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

jthackray
Copy link
Contributor

Fix test breakage in Vectorize/VPlanVerifierTest.cpp introduced in change 8499904 (typo).

Fix test breakage in Vectorize/VPlanVerifierTest.cpp introduced
in change 8499904 (typo).
@llvmbot
Copy link
Member

llvmbot commented May 15, 2025

@llvm/pr-subscribers-llvm-transforms

Author: Jonathan Thackray (jthackray)

Changes

Fix test breakage in Vectorize/VPlanVerifierTest.cpp introduced in change 8499904 (typo).


Full diff: https://github.com/llvm/llvm-project/pull/140079.diff

1 Files Affected:

  • (modified) llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp (+1-1)
diff --git a/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp b/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
index bd6fd9e711776..0cce111ccd22c 100644
--- a/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
+++ b/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
@@ -174,7 +174,7 @@ TEST_F(VPVerifierTest, VPPhiIncomingValueDoesntDominateIncomingBlock) {
                "  EMIT vp<%1> = phi [ vp<%2>, preheader ]",
                ::testing::internal::GetCapturedStderr().c_str());
 #else
-  EXPECT_STREQ("Incoming def at index 0 does not dominate incoming block!\n" ::
+  EXPECT_STREQ("Incoming def at index 0 does not dominate incoming block!\n", ::
                    testing::internal::GetCapturedStderr()
                        .c_str());
 #endif

Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
View the diff from clang-format here.
diff --git a/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp b/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
index 0cce111cc..30be4c679 100644
--- a/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
+++ b/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
@@ -174,9 +174,8 @@ TEST_F(VPVerifierTest, VPPhiIncomingValueDoesntDominateIncomingBlock) {
                "  EMIT vp<%1> = phi [ vp<%2>, preheader ]",
                ::testing::internal::GetCapturedStderr().c_str());
 #else
-  EXPECT_STREQ("Incoming def at index 0 does not dominate incoming block!\n", ::
-                   testing::internal::GetCapturedStderr()
-                       .c_str());
+  EXPECT_STREQ("Incoming def at index 0 does not dominate incoming block!\n",
+               ::testing::internal::GetCapturedStderr().c_str());
 #endif
 #endif
 }

@jthackray
Copy link
Contributor Author

This is breaking my builds (and probably other people's too) so I'm going to merge this now, as it's very low risk and fixes the issue.

@jthackray jthackray merged commit 6d942c5 into main May 15, 2025
6 of 11 checks passed
@jthackray jthackray deleted the users/jthackray/fix-test-breakage branch May 15, 2025 15:22
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants