Skip to content

[CIR] Upstream Vector support in elementTypeIfVector #140125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

[CIR] Upstream Vector support in elementTypeIfVector #140125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f624e
[CIR] Upstream Vector support in elementTypeIfVector
AmrDeveloper May 15, 2025
7f12718
Address code review comment
AmrDeveloper May 15, 2025
b2695e8
Use TypeSwitch
AmrDeveloper May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ namespace direct {
namespace {
/// If the given type is a vector type, return the vector's element type.
/// Otherwise return the given type unchanged.
// TODO(cir): Return the vector element type once we have support for vectors
// instead of the identity type.
mlir::Type elementTypeIfVector(mlir::Type type) {
assert(!cir::MissingFeatures::vectorType());
return type;
return llvm::TypeSwitch<mlir::Type, mlir::Type>(type)
.Case<cir::VectorType, mlir::VectorType>(
[](auto p) { return p->getElementType(); })
.Default([](mlir::Type p) { return p; });
}
} // namespace

Expand Down