[lldb-dap] launch the adapter from the workspace folder. #140604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the `cwd` option is empty this means the adapter is created in the home folder. Any relative file saved is in the home folder. The files should be relative to the current workspace folder.
|
@llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changesif the Any relative file saved is in the home folder. The files should be relative to the current workspace folder. Full diff: https://github.com/llvm/llvm-project/pull/140604.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts b/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
index 3a86d1f3f418f..d61b81e4c041f 100644
--- a/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
+++ b/lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts
@@ -184,6 +184,7 @@ export async function createDebugAdapterExecutable(
...configEnvironment,
...env,
},
+ cwd: workspaceFolder!!.uri.fsPath,
};
const dbgArgs = await getDAPArguments(workspaceFolder, configuration);
|
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
if the `cwd` option is empty this means the adapter is created in the home folder. Any relative file saved is in the home folder. The files should be relative to the current workspace folder.
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
if the `cwd` option is empty this means the adapter is created in the home folder. Any relative file saved is in the home folder. The files should be relative to the current workspace folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the
cwdoption is empty this means the adapter is created in the home folder.Any relative file saved is in the home folder. The files should be relative to the current workspace folder.