[LLVM][IR] Support target extension types in vectors #140630

arysef · 2025-05-19T21:48:12Z

This change is to support target extension types in vectors. The change allows sized target extension types to opt-in to being a valid vector element.
Allowing target extension types as vector elements will allow backends to use vector operations such as insertelement and extractelement on their target types with minimal changes.

RFC: https://discourse.llvm.org/t/rfc-supporting-sized-target-extension-types-in-vector/86431

github-actions · 2025-05-19T21:48:30Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvm/test/Verifier/target-ext-vector.ll

…n_vec

llvmbot · 2025-06-05T22:02:44Z

@llvm/pr-subscribers-llvm-ir

Author: None (arysef)

Changes

This change is to support target extension types in vectors. The change allows sized target extension types to opt-in to being a valid vector element.
Allowing target extension types as vector elements will allow backends to use vector operations such as insertelement and extractelement on their target types with minimal changes.

RFC: https://discourse.llvm.org/t/rfc-supporting-sized-target-extension-types-in-vector/86431

Full diff: https://github.com/llvm/llvm-project/pull/140630.diff

5 Files Affected:

(modified) llvm/docs/LangRef.rst (+2-1)
(modified) llvm/include/llvm/IR/DerivedTypes.h (+2)
(modified) llvm/lib/IR/Type.cpp (+17-4)
(added) llvm/test/Verifier/target-ext-vector-invalid.ll (+8)
(added) llvm/test/Verifier/target-ext-vector.ll (+20)

diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 0958f6a4b729b..e3b7c223b9c8d 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -4438,7 +4438,8 @@ the type size is smaller than the type's store size.
       < vscale x <# elements> x <elementtype> > ; Scalable vector
 
 The number of elements is a constant integer value larger than 0;
-elementtype may be any integer, floating-point or pointer type. Vectors
+elementtype may be any integer, floating-point, pointer type, or a sized  
+target extension type that has the `CanBeVectorElement` property. Vectors
 of size zero are not allowed. For scalable vectors, the total number of
 elements is a constant multiple (called vscale) of the specified number
 of elements; vscale is a positive integer that is unknown at compile time
diff --git a/llvm/include/llvm/IR/DerivedTypes.h b/llvm/include/llvm/IR/DerivedTypes.h
index 4d6bb1cfe3069..fa62bc09b61a3 100644
--- a/llvm/include/llvm/IR/DerivedTypes.h
+++ b/llvm/include/llvm/IR/DerivedTypes.h
@@ -845,6 +845,8 @@ class TargetExtType : public Type {
     /// This type may be allocated on the stack, either as the allocated type
     /// of an alloca instruction or as a byval function parameter.
     CanBeLocal = 1U << 2,
+    // This type may be used as an element in a vector.
+    CanBeVectorElement = 1U << 3,
   };
 
   /// Returns true if the target extension type contains the given property.
diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index 4b43b52014484..7858e24f4fce7 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -790,8 +790,13 @@ VectorType *VectorType::get(Type *ElementType, ElementCount EC) {
 }
 
 bool VectorType::isValidElementType(Type *ElemTy) {
-  return ElemTy->isIntegerTy() || ElemTy->isFloatingPointTy() ||
-         ElemTy->isPointerTy() || ElemTy->getTypeID() == TypedPointerTyID;
+  if (ElemTy->isIntegerTy() || ElemTy->isFloatingPointTy() ||
+      ElemTy->isPointerTy() || ElemTy->getTypeID() == TypedPointerTyID)
+    return true;
+  if (auto *TTy = dyn_cast<TargetExtType>(ElemTy))
+    return TTy->hasProperty(TargetExtType::CanBeVectorElement) &&
+           TTy->isSized();
+  return false;
 }
 
 //===----------------------------------------------------------------------===//
@@ -801,8 +806,9 @@ bool VectorType::isValidElementType(Type *ElemTy) {
 FixedVectorType *FixedVectorType::get(Type *ElementType, unsigned NumElts) {
   assert(NumElts > 0 && "#Elements of a VectorType must be greater than 0");
   assert(isValidElementType(ElementType) && "Element type of a VectorType must "
-                                            "be an integer, floating point, or "
-                                            "pointer type.");
+                                            "be an integer, floating point, "
+                                            "pointer type, or a valid target "
+                                            "extension type.");
 
   auto EC = ElementCount::getFixed(NumElts);
 
@@ -1037,6 +1043,13 @@ static TargetTypeInfo getTargetTypeInfo(const TargetExtType *Ty) {
                           TargetExtType::CanBeGlobal);
   }
 
+  // Type used to test vector element target extension property.
+  // Can be removed once a public target extension type uses CanBeVectorElement
+  if (Name == "llvm.test.vectorelement") {
+    return TargetTypeInfo(Type::getInt32Ty(C), TargetExtType::CanBeLocal,
+                          TargetExtType::CanBeVectorElement);
+  }
+
   return TargetTypeInfo(Type::getVoidTy(C));
 }
 
diff --git a/llvm/test/Verifier/target-ext-vector-invalid.ll b/llvm/test/Verifier/target-ext-vector-invalid.ll
new file mode 100644
index 0000000000000..59e3e78276a06
--- /dev/null
+++ b/llvm/test/Verifier/target-ext-vector-invalid.ll
@@ -0,0 +1,8 @@
+; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
+
+; CHECK: invalid vector element type
+
+define void @bad() {
+  %v = alloca <2 x target("spirv.Image")>
+  ret void
+}
\ No newline at end of file
diff --git a/llvm/test/Verifier/target-ext-vector.ll b/llvm/test/Verifier/target-ext-vector.ll
new file mode 100644
index 0000000000000..43d8360f39da0
--- /dev/null
+++ b/llvm/test/Verifier/target-ext-vector.ll
@@ -0,0 +1,20 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -passes=verify -S %s | FileCheck %s
+
+define <2 x target("llvm.test.vectorelement")> @vec_ops(<2 x target("llvm.test.vectorelement")> %x) {
+; CHECK-LABEL: define <2 x target("llvm.test.vectorelement")> @vec_ops(
+; CHECK-SAME: <2 x target("llvm.test.vectorelement")> [[X:%.*]]) {
+; CHECK-NEXT:    [[A:%.*]] = alloca <2 x target("llvm.test.vectorelement")>{{.*}}
+; CHECK-NEXT:    store <2 x target("llvm.test.vectorelement")> [[X]], ptr [[A]], {{.*}}
+; CHECK-NEXT:    [[LOAD:%.*]] = load <2 x target("llvm.test.vectorelement")>, ptr [[A]], {{.*}}
+; CHECK-NEXT:    [[ELT:%.*]] = extractelement <2 x target("llvm.test.vectorelement")> [[LOAD]], i64 0
+; CHECK-NEXT:    [[RES:%.*]] = insertelement <2 x target("llvm.test.vectorelement")> undef, target("llvm.test.vectorelement") [[ELT]], i64 1
+; CHECK-NEXT:    ret <2 x target("llvm.test.vectorelement")> [[RES]]
+;
+  %a = alloca <2 x target("llvm.test.vectorelement")>
+  store <2 x target("llvm.test.vectorelement")> %x, ptr %a
+  %load = load <2 x target("llvm.test.vectorelement")>, ptr %a
+  %elt = extractelement <2 x target("llvm.test.vectorelement")> %load, i64 0
+  %res = insertelement <2 x target("llvm.test.vectorelement")> undef, target("llvm.test.vectorelement") %elt, i64 1
+  ret <2 x target("llvm.test.vectorelement")> %res
+}

nikic

LGTM

llvm/docs/LangRef.rst

llvm/lib/IR/Type.cpp

github-actions · 2025-06-06T15:07:47Z

✅ With the latest revision this PR passed the undef deprecator.

llvm/test/Verifier/target-ext-vector.ll

paulwalker-arm · 2025-06-09T12:00:32Z

llvm/lib/IR/Type.cpp

+    if (this->Properties & TargetExtType::CanBeVectorElement)
+      assert(LayoutType->isSized() && "Vector element type must be sized");


Perhaps?

Suggested change

if (this->Properties & TargetExtType::CanBeVectorElement)

assert(LayoutType->isSized() && "Vector element type must be sized");

assert((!(this->Properties & TargetExtType::CanBeVectorElement) || LayoutType->isSized()) && "Vector element type must be sized");

github-actions · 2025-06-09T19:03:33Z

@arysef Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

arsenm · 2025-06-11T01:24:06Z

llvm/test/Verifier/target-ext-vector.ll

@@ -0,0 +1,20 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -passes=verify -S %s | FileCheck %s


Should run just llvm-as and be in test/Assembler. test/Verifier is for cases that fail

arsenm · 2025-06-11T01:24:16Z

llvm/test/Verifier/target-ext-vector-invalid.ll

@@ -0,0 +1,8 @@
+; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s


-disable-output instead of -o /dev/null

arsenm · 2025-06-11T01:24:23Z

llvm/test/Verifier/target-ext-vector-invalid.ll

+define void @bad() {
+  %v = alloca <2 x target("spirv.Image")>
+  ret void
+}


Missing newline error

This change is to support target extension types in vectors. The change allows sized target extension types to opt-in to being a valid vector element. Allowing target extension types as vector elements will allow backends to use vector operations such as `insertelement` and `extractelement` on their target types with minimal changes. RFC: https://discourse.llvm.org/t/rfc-supporting-sized-target-extension-types-in-vector/86431

Support target extension types in vectors

78a86cf

nikic reviewed May 22, 2025

View reviewed changes

llvm/test/Verifier/target-ext-vector.ll Outdated Show resolved Hide resolved

arysef added 3 commits May 27, 2025 21:46

Merge remote-tracking branch 'upstream/main' into dev/arysef/target_i…

9951121

…n_vec

Merge remote-tracking branch 'upstream/main' into dev/arysef/target_i…

11cbeee

…n_vec

add property to opt in to being a valid vector element type

3324462

arysef changed the title ~~[LLVM] Support target extension types in vectors~~ [LLVM][IR] Support target extension types in vectors Jun 5, 2025

arysef marked this pull request as ready for review June 5, 2025 22:02

llvmbot added the llvm:ir label Jun 5, 2025

nikic approved these changes Jun 6, 2025

View reviewed changes

llvm/docs/LangRef.rst Show resolved Hide resolved

llvm/lib/IR/Type.cpp Outdated Show resolved Hide resolved

llvm/lib/IR/Type.cpp Outdated Show resolved Hide resolved

nikic requested review from arsenm, fhahn and paulwalker-arm June 6, 2025 15:08

nikic reviewed Jun 6, 2025

View reviewed changes

llvm/test/Verifier/target-ext-vector.ll Outdated Show resolved Hide resolved

improve comments, move sized check into target type creation

9ad6926

paulwalker-arm approved these changes Jun 9, 2025

View reviewed changes

remove conditional, use only assert

56639dc

sstamenova merged commit 78af498 into llvm:main Jun 9, 2025
8 checks passed

arsenm reviewed Jun 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[LLVM][IR] Support target extension types in vectors #140630

[LLVM][IR] Support target extension types in vectors #140630

Uh oh!

arysef commented May 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

Uh oh!

llvmbot commented Jun 5, 2025

Uh oh!

nikic left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

paulwalker-arm Jun 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

arsenm Jun 11, 2025

Uh oh!

arsenm Jun 11, 2025

Uh oh!

arsenm Jun 11, 2025

Uh oh!

Uh oh!

		if (this->Properties & TargetExtType::CanBeVectorElement)
		assert(LayoutType->isSized() && "Vector element type must be sized");

	if (this->Properties & TargetExtType::CanBeVectorElement)
	assert(LayoutType->isSized() && "Vector element type must be sized");
	assert((!(this->Properties & TargetExtType::CanBeVectorElement) \|\| LayoutType->isSized()) && "Vector element type must be sized");

		@@ -0,0 +1,20 @@
		; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
		; RUN: opt -passes=verify -S %s \| FileCheck %s

		@@ -0,0 +1,8 @@
		; RUN: not llvm-as %s -o /dev/null 2>&1 \| FileCheck %s

[LLVM][IR] Support target extension types in vectors #140630

[LLVM][IR] Support target extension types in vectors #140630

Uh oh!

Conversation

arysef commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

Uh oh!

llvmbot commented Jun 5, 2025

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

paulwalker-arm Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

arsenm Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

arsenm Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

arsenm Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arysef commented May 19, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading