-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang][bytecode][NFC] Remove Frame.cpp #140750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.
@llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) ChangesThe file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files. Full diff: https://github.com/llvm/llvm-project/pull/140750.diff 3 Files Affected:
diff --git a/clang/lib/AST/ByteCode/Frame.cpp b/clang/lib/AST/ByteCode/Frame.cpp
deleted file mode 100644
index 16134aa1db36c..0000000000000
--- a/clang/lib/AST/ByteCode/Frame.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===--- Frame.cpp - Call frame for the VM and AST Walker -------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "Frame.h"
-
-using namespace clang;
-using namespace clang::interp;
-
-Frame::~Frame() {}
diff --git a/clang/lib/AST/ByteCode/Frame.h b/clang/lib/AST/ByteCode/Frame.h
index 079e4259b0ae8..b67a77a368997 100644
--- a/clang/lib/AST/ByteCode/Frame.h
+++ b/clang/lib/AST/ByteCode/Frame.h
@@ -24,7 +24,7 @@ namespace interp {
/// Base class for stack frames, shared between VM and walker.
class Frame {
public:
- virtual ~Frame();
+ virtual ~Frame() = default;
/// Generates a human-readable description of the call site.
virtual void describe(llvm::raw_ostream &OS) const = 0;
diff --git a/clang/lib/AST/CMakeLists.txt b/clang/lib/AST/CMakeLists.txt
index b5cd14b915673..d4fd7a7f16d53 100644
--- a/clang/lib/AST/CMakeLists.txt
+++ b/clang/lib/AST/CMakeLists.txt
@@ -74,7 +74,6 @@ add_clang_library(clangAST
ByteCode/Descriptor.cpp
ByteCode/Disasm.cpp
ByteCode/EvalEmitter.cpp
- ByteCode/Frame.cpp
ByteCode/Function.cpp
ByteCode/FunctionPointer.cpp
ByteCode/InterpBuiltin.cpp
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/3702 Here is the relevant piece of the build log for the reference
|
The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.
The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.
The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.
The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.