[mlir][tosa] Fix indexing in TosaToTensor #140906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-tosa Author: Shay Kleiman (shay-kl) ChangesChanged the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors. Full diff: https://github.com/llvm/llvm-project/pull/140906.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index 5f23a33049f87..4f565607e2167 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -362,7 +362,8 @@ class PadConverter : public OpConversionPattern<tosa::PadOp> {
// Setup the default constantAttr.
Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
- loc, padOp.getPadConst(), ValueRange({}));
+ loc, padOp.getPadConst(),
+ ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
if (!padConstant) {
return rewriter.notifyMatchFailure(
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.
shay-kl
force-pushed
the
shay-kl/fix-tensor-padop-indexing
branch
from
1c3eb32 to
216a5f2
Compare
CoTinker
reviewed
May 22, 2025
shay-kl
force-pushed
the
shay-kl/fix-tensor-padop-indexing
branch
from
f755b61 to
8cc4f3b
Compare
|
I don't have permissions, can you please land it? |
shay-kl
force-pushed
the
shay-kl/fix-tensor-padop-indexing
branch
from
8cc4f3b to
41151d6
Compare
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors. --------- Co-authored-by: Shay Kleiman <[email protected]>
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors. --------- Co-authored-by: Shay Kleiman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.