Skip to content

[TableGen] Remove wrong comment for CodeGenTarget ctor #141024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

tomershafir
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 22, 2025

@llvm/pr-subscribers-tablegen

Author: Tomer Shafir (tomershafir)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141024.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/Common/CodeGenTarget.cpp (-2)
diff --git a/llvm/utils/TableGen/Common/CodeGenTarget.cpp b/llvm/utils/TableGen/Common/CodeGenTarget.cpp
index 3169019bbd5b6..fb109ad50f14c 100644
--- a/llvm/utils/TableGen/Common/CodeGenTarget.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenTarget.cpp
@@ -70,8 +70,6 @@ std::string llvm::getQualifiedName(const Record *R) {
   return Namespace + "::" + R->getName().str();
 }
 
-/// getTarget - Return the current instance of the Target class.
-///
 CodeGenTarget::CodeGenTarget(const RecordKeeper &records)
     : Records(records), CGH(records), Intrinsics(records) {
   ArrayRef<const Record *> Targets = Records.getAllDerivedDefinitions("Target");

@tomershafir
Copy link
Contributor Author

@lenary can you pls merge? I dont have access yet

@lenary
Copy link
Member

lenary commented May 25, 2025

@tomershafir please can you a) make your email public on github (see here: https://llvm.org/docs/DeveloperPolicy.html#github-email-address), and b) update the commit to have the same author as your public email?

@tomershafir tomershafir force-pushed the tablegen-remove-wrong-comment branch from 494494f to 285150a Compare May 26, 2025 10:57
@tomershafir
Copy link
Contributor Author

@lenary sorry, done

@lenary lenary merged commit 47c04c7 into llvm:main May 28, 2025
11 checks passed
@lenary
Copy link
Member

lenary commented May 28, 2025

@lenary sorry, done

No worries, this is pretty common for new contributors to run into.

@tomershafir tomershafir deleted the tablegen-remove-wrong-comment branch May 28, 2025 16:57
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants