[CIR][NFC] Fix failing OpenACC NYI test #141155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test to check for the new message.
llvmbot
added
clang
|
@llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) ChangesA recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test to check for the new message. Full diff: https://github.com/llvm/llvm-project/pull/141155.diff 1 Files Affected:
diff --git a/clang/test/CIR/CodeGenOpenACC/openacc-not-implemented.cpp b/clang/test/CIR/CodeGenOpenACC/openacc-not-implemented.cpp
index 95b04a314ad8e..1dfb2edd128f8 100644
--- a/clang/test/CIR/CodeGenOpenACC/openacc-not-implemented.cpp
+++ b/clang/test/CIR/CodeGenOpenACC/openacc-not-implemented.cpp
@@ -3,7 +3,7 @@
void HelloWorld(int *A, int *B, int *C, int N) {
// expected-error@+2{{ClangIR code gen Not Yet Implemented: OpenACC Atomic Construct}}
-// expected-error@+1{{ClangIR code gen Not Yet Implemented: statement}}
+// expected-error@+1{{ClangIR code gen Not Yet Implemented: emitCompoundStmtWithoutScope: OpenACCAtomicConstruct}}
#pragma acc atomic
N = N + 1;
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/16418 Here is the relevant piece of the build log for the reference |
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test to check for the new message.
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test to check for the new message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the error message produced for unhandled compound statements without scope introduced a failure in an OpenACC test that was checking for the old error message. This change updates the test to check for the new message.