Skip to content

[lldb] Remove redundant control flow statements (NFC) #141183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

[lldb] Remove redundant control flow statements (NFC) #141183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lldb/include/lldb/Interpreter/ScriptInterpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,10 +500,8 @@ class ScriptInterpreter : public PluginInterface {
return false;
}

virtual void OptionParsingStartedForCommandObject(
StructuredData::GenericSP cmd_obj_sp) {
return;
}
virtual void
OptionParsingStartedForCommandObject(StructuredData::GenericSP cmd_obj_sp) {}

virtual uint32_t
GetFlagsForCommandObject(StructuredData::GenericSP cmd_obj_sp) {
Expand Down
2 changes: 1 addition & 1 deletion lldb/include/lldb/Target/Process.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ class Process : public std::enable_shared_from_this<Process>,

/// The underlying plugin might store the low-level communication history for
/// this session. Dump it into the provided stream.
virtual void DumpPluginHistory(Stream &s) { return; }
virtual void DumpPluginHistory(Stream &s) {}

/// Launch a new process.
///
Expand Down
1 change: 0 additions & 1 deletion lldb/source/Commands/CommandObjectDiagnostics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class CommandObjectDiagnosticsDump : public CommandObjectParsed {
result.GetOutputStream() << "diagnostics written to " << *directory << '\n';

result.SetStatus(eReturnStatusSuccessFinishResult);
return;
}

CommandOptions m_options;
Expand Down
2 changes: 0 additions & 2 deletions lldb/source/Commands/CommandObjectTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,6 @@ class CommandObjectTargetDelete : public CommandObjectParsed {
result.GetOutputStream().Printf("%u targets deleted.\n",
(uint32_t)num_targets_to_delete);
result.SetStatus(eReturnStatusSuccessFinishResult);

return;
}

OptionGroupOptions m_option_group;
Expand Down
1 change: 0 additions & 1 deletion lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,6 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
template <typename T, typename U>
void ReverseTransform(T &original_arg, U transformed_arg, Status &error) {
// If U is not a PythonObject, don't touch it!
return;
}

template <typename T>
Expand Down
1 change: 0 additions & 1 deletion lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ void AppleDWARFIndex::GetTypes(
m_module.LogMessage(log, "FindByNameAndTag()");
const dw_tag_t expected_tag = context[0].tag;
SearchFor(*m_apple_types_up, expected_name, callback, expected_tag);
return;
}

void AppleDWARFIndex::GetNamespaces(
Expand Down
Loading