[CodeGen] Remove redundant calls to std::unique_ptr<T>::get (NFC) #141191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/141191.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp
index 3d20756774708..21896c94c86b4 100644
--- a/clang/lib/CodeGen/CGDebugInfo.cpp
+++ b/clang/lib/CodeGen/CGDebugInfo.cpp
@@ -134,10 +134,9 @@ void CGDebugInfo::addInstSourceAtomMetadata(llvm::Instruction *I,
// Each instruction can only be attributed to one source atom (a limitation of
// the implementation). If this instruction is already part of a source atom,
// pick the group in which it has highest precedence (lowest rank).
- if (DL.get()->getAtomGroup() && DL.get()->getAtomRank() &&
- DL.get()->getAtomRank() < Rank) {
- Group = DL.get()->getAtomGroup();
- Rank = DL.get()->getAtomRank();
+ if (DL->getAtomGroup() && DL->getAtomRank() && DL->getAtomRank() < Rank) {
+ Group = DL->getAtomGroup();
+ Rank = DL->getAtomRank();
}
// Update the function-local watermark so we don't reuse this number for
|
|
@llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/141191.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp
index 3d20756774708..21896c94c86b4 100644
--- a/clang/lib/CodeGen/CGDebugInfo.cpp
+++ b/clang/lib/CodeGen/CGDebugInfo.cpp
@@ -134,10 +134,9 @@ void CGDebugInfo::addInstSourceAtomMetadata(llvm::Instruction *I,
// Each instruction can only be attributed to one source atom (a limitation of
// the implementation). If this instruction is already part of a source atom,
// pick the group in which it has highest precedence (lowest rank).
- if (DL.get()->getAtomGroup() && DL.get()->getAtomRank() &&
- DL.get()->getAtomRank() < Rank) {
- Group = DL.get()->getAtomGroup();
- Rank = DL.get()->getAtomRank();
+ if (DL->getAtomGroup() && DL->getAtomRank() && DL->getAtomRank() < Rank) {
+ Group = DL->getAtomGroup();
+ Rank = DL->getAtomRank();
}
// Update the function-local watermark so we don't reuse this number for
|
|
@llvm/pr-subscribers-debuginfo Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/141191.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp
index 3d20756774708..21896c94c86b4 100644
--- a/clang/lib/CodeGen/CGDebugInfo.cpp
+++ b/clang/lib/CodeGen/CGDebugInfo.cpp
@@ -134,10 +134,9 @@ void CGDebugInfo::addInstSourceAtomMetadata(llvm::Instruction *I,
// Each instruction can only be attributed to one source atom (a limitation of
// the implementation). If this instruction is already part of a source atom,
// pick the group in which it has highest precedence (lowest rank).
- if (DL.get()->getAtomGroup() && DL.get()->getAtomRank() &&
- DL.get()->getAtomRank() < Rank) {
- Group = DL.get()->getAtomGroup();
- Rank = DL.get()->getAtomRank();
+ if (DL->getAtomGroup() && DL->getAtomRank() && DL->getAtomRank() < Rank) {
+ Group = DL->getAtomGroup();
+ Rank = DL->getAtomRank();
}
// Update the function-local watermark so we don't reuse this number for
|
tgymnich
approved these changes
May 23, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.