Skip to content

Resolve Failing LIT test on Fuchsia #141253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

david-salinas
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: David Salinas (david-salinas)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141253.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-objdump/Offloading/fatbin.test (+1)
diff --git a/llvm/test/tools/llvm-objdump/Offloading/fatbin.test b/llvm/test/tools/llvm-objdump/Offloading/fatbin.test
index 40cb26896cd86..3d3c5157b7669 100644
--- a/llvm/test/tools/llvm-objdump/Offloading/fatbin.test
+++ b/llvm/test/tools/llvm-objdump/Offloading/fatbin.test
@@ -1,6 +1,7 @@
 ## Test that --offloading with a fatbin works correctly
 
 # REQUIRES: target={{x86_64-.*-linux.*}}
+# REQUIRES: amdgpu-registered-target
 # RUN: yaml2obj %s -o %t.elf
 # RUN: llvm-objdump --offloading %t.elf 
 # RUN: llvm-objdump -d %t.elf.0.hipv4-amdgcn-amd-amdhsa--gfx908 | FileCheck %s 

@david-salinas david-salinas requested review from ilovepi and kzhuravl May 23, 2025 16:47
Copy link
Contributor

@ilovepi ilovepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :)

@ilovepi
Copy link
Contributor

ilovepi commented May 23, 2025

Also, for the record, our toolchain is just a regular Linux toolchain (or Windows/Mac too). It's just the toolchain we use to build Fuchsia, it doesn't run on it.

@david-salinas david-salinas merged commit 7b4d2a0 into llvm:main May 23, 2025
13 checks passed
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants