Skip to content

[LLDB] Fix warning about unused private members. #141259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

cmtice
Copy link
Contributor

@cmtice cmtice commented May 23, 2025

No description provided.

@cmtice cmtice requested a review from JDevlieghere as a code owner May 23, 2025 17:09
@llvmbot llvmbot added the lldb label May 23, 2025
@cmtice cmtice requested a review from kazutakahirata May 23, 2025 17:09
@llvmbot
Copy link
Member

llvmbot commented May 23, 2025

@llvm/pr-subscribers-lldb

Author: None (cmtice)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/141259.diff

1 Files Affected:

  • (modified) lldb/include/lldb/ValueObject/DILParser.h (+4)
diff --git a/lldb/include/lldb/ValueObject/DILParser.h b/lldb/include/lldb/ValueObject/DILParser.h
index bd152940d28f6..485d84d27162e 100644
--- a/lldb/include/lldb/ValueObject/DILParser.h
+++ b/lldb/include/lldb/ValueObject/DILParser.h
@@ -71,6 +71,10 @@ class DILParser {
 
   bool UseSynthetic() { return m_use_synthetic; }
 
+  bool UseFragileIvar() { return m_fragile_ivar; }
+
+  bool CheckPtrVsMember() { return m_check_ptr_vs_member; }
+
   lldb::DynamicValueType UseDynamic() { return m_use_dynamic; }
 
 private:

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've verified that your patch fixes the warning. Thanks! I suppose you're going to use these accessors in the near future !?

@cmtice
Copy link
Contributor Author

cmtice commented May 23, 2025

LGTM. I've verified that your patch fixes the warning. Thanks! I suppose you're going to use these accessors in the near future !?

Yes, that is the plan.

@cmtice cmtice merged commit b878e0d into llvm:main May 23, 2025
10 of 12 checks passed
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants