[mlir][linalg] Simplify runtime op verification test case #141454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesSimplify one of the test cases to make it easier to understand what is being verified. Full diff: https://github.com/llvm/llvm-project/pull/141454.diff 1 Files Affected:
diff --git a/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
index 5a1bcc7d893bc..dc56a3c52baad 100644
--- a/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
+++ b/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
@@ -109,15 +109,12 @@ func.func @main() {
#identity1D = affine_map<(d0) -> (d0)>
func.func @simple_add(%arg0: tensor<?xf32>, %arg1: tensor<?xf32>) -> (tensor<?xf32>) {
- %c0 = arith.constant 0 : index
- %dim = tensor.dim %arg0, %c0 : tensor<?xf32>
- %result = tensor.empty(%dim) : tensor<?xf32>
%0 = linalg.generic {
- indexing_maps = [#identity1D, #identity1D, #identity1D],
+ indexing_maps = [#identity1D, #identity1D],
iterator_types = ["parallel"]
- } ins(%arg0, %arg1 : tensor<?xf32>, tensor<?xf32>)
- outs(%result : tensor<?xf32>) {
- ^bb0(%gen_arg1: f32, %gen_arg2: f32, %out: f32) :
+ } ins(%arg0 : tensor<?xf32>)
+ outs(%arg1 : tensor<?xf32>) {
+ ^bb0(%gen_arg1: f32, %gen_arg2: f32) :
%tmp1 = arith.addf %gen_arg1, %gen_arg2 : f32
linalg.yield %tmp1 : f32
} -> tensor<?xf32>
|
|
@llvm/pr-subscribers-mlir-linalg Author: Matthias Springer (matthias-springer) ChangesSimplify one of the test cases to make it easier to understand what is being verified. Full diff: https://github.com/llvm/llvm-project/pull/141454.diff 1 Files Affected:
diff --git a/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir b/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
index 5a1bcc7d893bc..dc56a3c52baad 100644
--- a/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
+++ b/mlir/test/Integration/Dialect/Linalg/CPU/runtime-verification.mlir
@@ -109,15 +109,12 @@ func.func @main() {
#identity1D = affine_map<(d0) -> (d0)>
func.func @simple_add(%arg0: tensor<?xf32>, %arg1: tensor<?xf32>) -> (tensor<?xf32>) {
- %c0 = arith.constant 0 : index
- %dim = tensor.dim %arg0, %c0 : tensor<?xf32>
- %result = tensor.empty(%dim) : tensor<?xf32>
%0 = linalg.generic {
- indexing_maps = [#identity1D, #identity1D, #identity1D],
+ indexing_maps = [#identity1D, #identity1D],
iterator_types = ["parallel"]
- } ins(%arg0, %arg1 : tensor<?xf32>, tensor<?xf32>)
- outs(%result : tensor<?xf32>) {
- ^bb0(%gen_arg1: f32, %gen_arg2: f32, %out: f32) :
+ } ins(%arg0 : tensor<?xf32>)
+ outs(%arg1 : tensor<?xf32>) {
+ ^bb0(%gen_arg1: f32, %gen_arg2: f32) :
%tmp1 = arith.addf %gen_arg1, %gen_arg2 : f32
linalg.yield %tmp1 : f32
} -> tensor<?xf32>
|
chelini
approved these changes
May 26, 2025
matthias-springer
deleted the
users/matthias-springer/simplify_test_linalg
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/13321 Here is the relevant piece of the build log for the reference |
matthias-springer
added a commit
that referenced
this pull request
May 26, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/13672 Here is the relevant piece of the build log for the reference |
matthias-springer
added a commit
that referenced
this pull request
May 26, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/6908 Here is the relevant piece of the build log for the reference |
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Simplify one of the test cases to make it easier to understand what is being verified.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify one of the test cases to make it easier to understand what is being verified.