Skip to content

[MLIR] Add a missing newline to debug output. NFC #141531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

AlexDenisov
Copy link
Member

@AlexDenisov AlexDenisov commented May 26, 2025

Before:

** Erase   : 'scf.yield'(0x6000037b1630)
** Insert Block into detached Region (nullptr parent op)'        ** Insert Block into detached Region (nullptr parent op)'        ** Insert  : 'scf.if'(0x6000025b8140)
** Erase   : 'scf.if'(0x600003ab0780)

After:

** Erase   : 'scf.yield'(0x600003128b90)
** Insert Block into detached Region (nullptr parent op)'
** Insert Block into detached Region (nullptr parent op)'
** Insert  : 'scf.if'(0x6000023206e0)

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels May 26, 2025
@llvmbot
Copy link
Member

llvmbot commented May 26, 2025

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Alex Denisov (AlexDenisov)

Changes

Before:

        ** Erase   : 'scf.yield'(0x6000037b1630)
        ** Insert Block into detached Region (nullptr parent op)'        ** Insert Block into detached Region (nullptr parent op)'        ** Insert  : 'scf.if'(0x6000025b8140)
        ** Erase   : 'scf.if'(0x600003ab0780)

After:

        ** Erase   : 'scf.yield'(0x600003128b90)
        ** Insert Block into detached Region (nullptr parent op)'
        ** Insert Block into detached Region (nullptr parent op)'
        ** Insert  : 'scf.if'(0x6000023206e0)

Full diff: https://github.com/llvm/llvm-project/pull/141531.diff

1 Files Affected:

  • (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (+1-1)
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 02657b500ebfa..7de26d7cfa84d 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1605,7 +1605,7 @@ void ConversionPatternRewriterImpl::notifyBlockInserted(
                              << "'(" << parent << ")\n";
         } else {
           logger.startLine()
-              << "** Insert Block into detached Region (nullptr parent op)'";
+              << "** Insert Block into detached Region (nullptr parent op)'\n";
         }
       });
 

@j2kun j2kun merged commit da4958a into llvm:main May 26, 2025
14 checks passed
@AlexDenisov AlexDenisov deleted the alexdenisov/add-missing-newline branch May 27, 2025 06:37
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Jun 3, 2025
Before:

```
** Erase   : 'scf.yield'(0x6000037b1630)
** Insert Block into detached Region (nullptr parent op)'        ** Insert Block into detached Region (nullptr parent op)'        ** Insert  : 'scf.if'(0x6000025b8140)
** Erase   : 'scf.if'(0x600003ab0780)
```

After:

```
** Erase   : 'scf.yield'(0x600003128b90)
** Insert Block into detached Region (nullptr parent op)'
** Insert Block into detached Region (nullptr parent op)'
** Insert  : 'scf.if'(0x6000023206e0)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants